jenkins-bot has submitted this change and it was merged.
Change subject: Fix for clearing items in a group element
......................................................................
Fix for clearing items in a group element
This resolves an issue introduced in I02b933d.
Setting the element group to null must be inside a loop, so the logic was
basically shamefully bad.
Change-Id: I76bc17fdb375b18b17cfdb47961f0a00fa12b707
---
M src/elements/OO.ui.GroupElement.js
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
Awjrichards: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/src/elements/OO.ui.GroupElement.js
b/src/elements/OO.ui.GroupElement.js
index 6761ae1..f8341c6 100644
--- a/src/elements/OO.ui.GroupElement.js
+++ b/src/elements/OO.ui.GroupElement.js
@@ -127,12 +127,13 @@
var i, len, item;
// Remove all items
- if ( this.aggregate ) {
- for ( i = 0, len = this.items.length; i < len; i++ ) {
+ for ( i = 0, len = this.items.length; i < len; i++ ) {
+ item = this.items[i];
+ if ( this.aggregate ) {
item.disconnect( this );
}
+ item.setElementGroup( null );
}
- item.setElementGroup( null );
this.items = [];
this.$items.detach();
this.$items = this.$( [] );
--
To view, visit https://gerrit.wikimedia.org/r/113309
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76bc17fdb375b18b17cfdb47961f0a00fa12b707
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <[email protected]>
Gerrit-Reviewer: Awjrichards <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
