Mdale has submitted this change and it was merged. Change subject: Fix java fallback support on browsers that don't natively do ogg. ......................................................................
Fix java fallback support on browsers that don't natively do ogg. TMH was comparing the mime type 'video/ogg; codec="theora, vorbis"' to 'video/ogg; codec="theora,vorbis"' when checking if cortado could play the video. The mime checking code is not very robust and doing string equality comparisions. As a result in the different spacing, TMH determined that the java cortado applet could not play theora videos. This should significantly improve the number of desktop MSIE and Safari users who can play our videos. A future todo would be to make TMH more robust about how it checks mime types. Bug: 60259 Change-Id: I4072ebc592f791be9c3ed898ebb46217e6351cb9 --- M MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Mdale: Verified; Looks good to me, approved diff --git a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js index 5f1a6fc..80960a4 100644 --- a/MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js +++ b/MwEmbedModules/EmbedPlayer/resources/mw.EmbedTypes.js @@ -25,7 +25,7 @@ var cortadoPlayer = new mw.MediaPlayer( 'cortado', [ 'video/ogg', 'video/ogg; codecs="theora"', - 'video/ogg; codecs="theora,vorbis"', + 'video/ogg; codecs="theora, vorbis"', 'audio/ogg', 'audio/ogg; codecs="vorbis"', 'application/ogg' @@ -230,7 +230,7 @@ } // Test for ogg - if ( dummyvid.canPlayType( 'video/ogg; codecs="theora,vorbis"' ) ) { + if ( dummyvid.canPlayType( 'video/ogg; codecs="theora, vorbis"' ) ) { this.mediaPlayers.addPlayer( oggNativePlayer ); // older versions of safari do not support canPlayType, // but xiph qt registers mimetype via quicktime plugin -- To view, visit https://gerrit.wikimedia.org/r/108646 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4072ebc592f791be9c3ed898ebb46217e6351cb9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: Brian Wolff <bawolff...@gmail.com> Gerrit-Reviewer: Gilles <gdu...@wikimedia.org> Gerrit-Reviewer: MarkTraceur <mtrac...@member.fsf.org> Gerrit-Reviewer: Mdale <md...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits