Brion VIBBER has submitted this change and it was merged.
Change subject: Do not crash when user has changed password
......................................................................
Do not crash when user has changed password
Change-Id: Ieeb10f0e6d053d8e0187c90a61e4de9023c4c36c
---
M wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git
a/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
b/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
index a1779fb..29bbf9e 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditSectionActivity.java
@@ -186,7 +186,13 @@
new LoginTask(app, app.getPrimarySite(),
user.getUsername(), user.getPassword()) {
@Override
public void onFinish(String result) {
- doSave();
+ if (result.equals("Success")) {
+ doSave();
+ } else {
+ progressDialog.dismiss();
+ Utils.crossFade(sectionText,
sectionError);
+
sectionError.setVisibility(View.VISIBLE);
+ }
}
}.execute();
return;
--
To view, visit https://gerrit.wikimedia.org/r/113370
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeb10f0e6d053d8e0187c90a61e4de9023c4c36c
Gerrit-PatchSet: 2
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
