Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/114625

Change subject: Reuse readDbListFile in populateWikiversions
......................................................................

Reuse readDbListFile in populateWikiversions

Change-Id: I0321e0a92a5455b0aacb0613e8aed122154eacee
---
M multiversion/populateWikiversions
1 file changed, 3 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/25/114625/1

diff --git a/multiversion/populateWikiversions 
b/multiversion/populateWikiversions
index 2953492..cc787fc 100755
--- a/multiversion/populateWikiversions
+++ b/multiversion/populateWikiversions
@@ -4,6 +4,8 @@
 error_reporting( E_ALL );
 require_once( __DIR__ . '/defines.php' );
 require_once( __DIR__ . '/MWRealm.php' );
+require_once( __DIR__ . '/MWWikiversions.php' );
+
 /*
  * Populate wikiversions.cdb file using all the items in all.dblist
  * as keys, each having a value of the specified MediaWiki version.
@@ -31,12 +33,7 @@
                exit( 1 );
        }
 
-       $path = getRealmSpecificFilename( "$common/all.dblist" );
-       $dbList = array_filter( explode( "\n", file_get_contents( $path ) ) );
-       if ( !count( $dbList ) ) {
-               print "Unable to read $path.\n";
-               exit( 1 );
-       }
+       $dbList = MWWikiversions::readDbListFile( getRealmSpecificFilename( 
MULTIVER_COMMON_HOME . '/all.dblist' ) );
 
        $datList = "";
        foreach ( $dbList as $dbName ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/114625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0321e0a92a5455b0aacb0613e8aed122154eacee
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy <re...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to