Reedy has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/114630

Change subject: Fixup versions in populateWikiversions
......................................................................

Fixup versions in populateWikiversions

Remove weird "confirm" parameter

Change-Id: I67ffa56b048829bfff6658ae709cc814b999900d
---
M multiversion/populateWikiversions
1 file changed, 5 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config 
refs/changes/30/114630/1

diff --git a/multiversion/populateWikiversions 
b/multiversion/populateWikiversions
index 914aa78..a368449 100755
--- a/multiversion/populateWikiversions
+++ b/multiversion/populateWikiversions
@@ -11,8 +11,7 @@
  * as keys, each having a value of the specified MediaWiki version.
  * This means that all will be configured to run that version.
  *
- * The first argument is the version, typically of the format "php-X.XX".
- * The second argument is a confirmation ("confirm").
+ * The first argument is the version, typically of the format "php-X.XXwmfX".
  *
  * @return void
  */
@@ -20,15 +19,15 @@
        global $argv;
 
        $argsValid = false;
-       if ( count( $argv ) >= 3 && $argv[2] === 'confirm' ) {
-               $version = $argv[1]; // e.g. "php-X.XX"
-               if ( preg_match( '/^php-(?:\d+\.\d+|trunk)(?:-\d)?$/', $version 
) ) {
+       if ( count( $argv ) == 2 ) {
+               $version = $argv[1]; // e.g. "php-X.XXwmfX"
+               if ( preg_match( '/^php-(\d+\.\d+wmf\d+|master)$/', $version ) 
) {
                        $argsValid = true;
                }
        }
 
        if ( !$argsValid ) {
-               print "Usage: populateWikiversions php-X.XX confirm\n";
+               print "Usage: populateWikiversions php-X.XXwmfX\n";
                exit( 1 );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/114630
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I67ffa56b048829bfff6658ae709cc814b999900d
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Reedy <re...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to