jenkins-bot has submitted this change and it was merged. Change subject: jquery.suggestions: Do not duplicate keypress logic ......................................................................
jquery.suggestions: Do not duplicate keypress logic This is handled in keyup/keypress handlers, no need to repeat it twice. Change-Id: I3ddcd21136b44eedcec53b1ecc91bad38f697402 --- M resources/jquery/jquery.suggestions.js 1 file changed, 0 insertions(+), 18 deletions(-) Approvals: Yuvipanda: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/jquery/jquery.suggestions.js b/resources/jquery/jquery.suggestions.js index 3774d0c..c4e95a4 100644 --- a/resources/jquery/jquery.suggestions.js +++ b/resources/jquery/jquery.suggestions.js @@ -591,24 +591,6 @@ // Store key pressed to handle later context.data.keypressed = e.which; context.data.keypressedCount = 0; - - switch ( context.data.keypressed ) { - // This preventDefault logic is duplicated from - // $.suggestions.keypress(), which sucks - // Arrow down - case 40: - e.preventDefault(); - e.stopImmediatePropagation(); - break; - // Arrow up, Escape and Enter - case 38: - case 27: - case 13: - if ( context.data.$container.is( ':visible' ) ) { - e.preventDefault(); - e.stopImmediatePropagation(); - } - } } ) .keypress( function ( e ) { context.data.keypressedCount++; -- To view, visit https://gerrit.wikimedia.org/r/82814 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3ddcd21136b44eedcec53b1ecc91bad38f697402 Gerrit-PatchSet: 5 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net> Gerrit-Reviewer: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Yuvipanda <yuvipa...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits