jenkins-bot has submitted this change and it was merged.
Change subject: doc: Use lowercase types where primitives (not objects) are
expected
......................................................................
doc: Use lowercase types where primitives (not objects) are expected
Fixed:
* ve.dm.MetaList.js (added in I74a9a2139)
* ve.ce.Document.js (added in Ifc01b8e5d)
Change-Id: Id758818ded5b892233bfc0d62f0f435da480c950
---
M modules/ve/ce/ve.ce.Document.js
M modules/ve/dm/ve.dm.MetaList.js
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Trevor Parscal: Looks good to me, approved
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ce/ve.ce.Document.js b/modules/ve/ce/ve.ce.Document.js
index 3c21fb2..0df7a8d 100644
--- a/modules/ve/ce/ve.ce.Document.js
+++ b/modules/ve/ce/ve.ce.Document.js
@@ -274,7 +274,7 @@
*
* @method
* @param {ve.Range} range Selection range
- * @returns {String} 'rtl' or 'ltr' as response
+ * @returns {string} 'rtl' or 'ltr' as response
*/
ve.ce.Document.prototype.getDirectionFromRange = function ( range ) {
var effectiveNode,
diff --git a/modules/ve/dm/ve.dm.MetaList.js b/modules/ve/dm/ve.dm.MetaList.js
index bed2ffa..33d0b80 100644
--- a/modules/ve/dm/ve.dm.MetaList.js
+++ b/modules/ve/dm/ve.dm.MetaList.js
@@ -61,8 +61,8 @@
/**
* @event remove
* @param {ve.dm.MetaItem} item Item that was removed
- * @param {Number} offset Linear model offset that the item was at
- * @param {Number} index Index within that offset the item was at
+ * @param {number} offset Linear model offset that the item was at
+ * @param {number} index Index within that offset the item was at
*/
/* Methods */
@@ -339,8 +339,8 @@
*
* Pass a plain object rather than a MetaItem into this function unless you
know what you're doing.
* @param {Object|ve.dm.MetaItem} meta Metadata element (or MetaItem) to insert
- * @param {Number} [offset] Offset to insert the new metadata, or undefined to
add to the end
- * @param {Number} [index] Index to insert the new metadata, or undefined to
add to the end
+ * @param {number} [offset] Offset to insert the new metadata, or undefined to
add to the end
+ * @param {number} [index] Index to insert the new metadata, or undefined to
add to the end
*/
ve.dm.MetaList.prototype.insertMeta = function ( meta, offset, index ) {
var tx;
--
To view, visit https://gerrit.wikimedia.org/r/114628
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id758818ded5b892233bfc0d62f0f435da480c950
Gerrit-PatchSet: 3
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
Gerrit-Reviewer: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
