jenkins-bot has submitted this change and it was merged.
Change subject: Don't let the user set a static redirect flag on a non-redirect
......................................................................
Don't let the user set a static redirect flag on a non-redirect
Bug: 61865
Change-Id: I417d7a5e179f46022652a267de41fb4de8525391
---
M modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
b/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
index 9e32e97..4263ba1 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
@@ -317,7 +317,7 @@
if ( currentStaticRedirectItem && ( !newStaticRedirectState ||
!newRedirectData ) ) {
currentStaticRedirectItem.remove();
}
- if ( !currentStaticRedirectItem && newStaticRedirectState ) {
+ if ( !currentStaticRedirectItem && newStaticRedirectState &&
newRedirectData ) {
this.metaList.insertMeta( { 'type': 'mwStaticRedirect'
} );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/115239
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I417d7a5e179f46022652a267de41fb4de8525391
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
