Mattflaschen has uploaded a new change for review.
https://gerrit.wikimedia.org/r/115526
Change subject: Use mediawiki.ui.button instead of mediaiki.ui
......................................................................
Use mediawiki.ui.button instead of mediaiki.ui
* 9e4e58bce8d10f65cf298b39f48e86c41b6a82b8 separated mediawiki.ui.button
into a separate module (for modularity, and potentially to allow
wiki content to use mw.ui buttons by default in the future).
* Currently, the button code is in both mediawiki.ui and
mediawiki.ui.button for backwards compatibility. However, it will be
removed from mediawiki.ui when existing uses transition over; see
I5bd23434961497d49293956c92b46ab3a6f14a41 .
* ContentTranslation does not use any core mw.ui features other than
buttons. If it does in the future, 'mediawiki.ui' can be added.
* Some 'mediawiki.ui.button' uses must work without JS, so they have
to use addModuleStyles. Thus, the best practice is for all to do so
when possible to avoid double-loading.
Change-Id: I2e1f894517d5e558099590dd72907b958dcd83ad
---
M Resources.php
M specials/SpecialContentTranslation.php
2 files changed, 1 insertion(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/26/115526/1
diff --git a/Resources.php b/Resources.php
index 6ad38d5..cc44d7b 100644
--- a/Resources.php
+++ b/Resources.php
@@ -29,7 +29,6 @@
'base/styles/ext.cx.base.less',
),
'dependencies' => array(
- 'mediawiki.ui',
'ext.cx.model',
'ext.cx.header',
'ext.cx.source',
diff --git a/specials/SpecialContentTranslation.php
b/specials/SpecialContentTranslation.php
index fd619f8..88cd217 100644
--- a/specials/SpecialContentTranslation.php
+++ b/specials/SpecialContentTranslation.php
@@ -29,6 +29,7 @@
if ( !($user->isLoggedIn() ) ) {
$out->addHTML( $this->msg( 'cx-special-login-error' ) );
} else {
+ $out->addModuleStyles( 'mediawiki.ui.button' );
$out->addModules( 'ext.cx.base' );
$this->setHeaders();
$out->setArticleBodyOnly( true );
--
To view, visit https://gerrit.wikimedia.org/r/115526
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e1f894517d5e558099590dd72907b958dcd83ad
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
