Trevor Parscal has uploaded a new change for review.
https://gerrit.wikimedia.org/r/115545
Change subject: Cleanup duplication in TransclusionDialog classes
......................................................................
Cleanup duplication in TransclusionDialog classes
Change-Id: I96bcd07a1548b21c8a11b9d2990400d4f48e044a
---
M modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js
M modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
M modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
3 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/45/115545/1
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js
index 46a1c11..1563fff 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWAdvancedTransclusionDialog.js
@@ -36,8 +36,6 @@
ve.ui.MWAdvancedTransclusionDialog.static.title =
OO.ui.deferMsg( 'visualeditor-dialog-transclusion-title' );
-ve.ui.MWAdvancedTransclusionDialog.static.icon = 'template';
-
/* Methods */
/**
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
index 6cfec20..3edc322 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
@@ -34,9 +34,7 @@
ve.ui.MWTemplateDialog.static.name = 'transclusion';
ve.ui.MWTemplateDialog.static.title =
- OO.ui.deferMsg( 'visualeditor-dialog-transclusion-title' );
-
-ve.ui.MWTemplateDialog.static.icon = 'template';
+ OO.ui.deferMsg( 'visualeditor-dialog-template-title' );
/* Methods */
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
index 6e40961..8c6fc9b 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTransclusionDialog.js
@@ -131,10 +131,14 @@
/**
* Get a booklet layout widget.
*
- * @return {OO.ui.BookletLayout} Configured widget
+ * @abstract
+ * @returns {OO.ui.BookletLayout} Configured widget
+ * @throws {Error} If method is not overridden in subclass
*/
ve.ui.MWTransclusionDialog.prototype.getBookletLayout = function () {
- return new OO.ui.BookletLayout( { '$': this.$, 'continuous': true } );
+ throw new Error(
+ 'getBookletLayout must be overridden in subclass of
ve.ui.MWTransclusionDialog'
+ );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/115545
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96bcd07a1548b21c8a11b9d2990400d4f48e044a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <tpars...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
