Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/115680
Change subject: User-definable animation duration instead of constant time
......................................................................
User-definable animation duration instead of constant time
jQuery provides names for default animation durations that can be
changed or turned off by the user if he wants. Constant numbers
can't.
This also fixes a comparison that made it impossible to set the
duration to 0.
This patch does not remove or change any animation as long as the
user does not touch the jQuery defaults.
Change-Id: I73a16f871ad79c77374b0c1e1abef39c8c3b6e95
---
M
lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
M lib/resources/jquery.wikibase/toolbar/edittoolbar.js
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/80/115680/1
diff --git
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
index b2c7851..0822312 100644
---
a/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
+++
b/lib/resources/jquery.wikibase/jquery.wikibase.snakview/snakview.variations.Value.js
@@ -210,7 +210,7 @@
{ height: newHeight },
{
queue:
heightAnimationQueue,
- duration: 250,
+ duration: 'fast',
//defaults to 200
progress: function(
animation, progress, remainingMs ) {
$.ui.inputextender.redrawVisibleExtensions();
}
diff --git a/lib/resources/jquery.wikibase/toolbar/edittoolbar.js
b/lib/resources/jquery.wikibase/toolbar/edittoolbar.js
index 17d0502..22cbcb7 100644
--- a/lib/resources/jquery.wikibase/toolbar/edittoolbar.js
+++ b/lib/resources/jquery.wikibase/toolbar/edittoolbar.js
@@ -273,8 +273,8 @@
options = {};
}
- if ( !options.duration ) {
- options.duration = 200; // default fade duration
+ if ( options.duration === undefined ) {
+ options.duration = 'fast'; //defaults to 200
}
if ( !options.message ) { // show toolbar
--
To view, visit https://gerrit.wikimedia.org/r/115680
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73a16f871ad79c77374b0c1e1abef39c8c3b6e95
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
