jenkins-bot has submitted this change and it was merged. Change subject: Using @custom-browser Cucumber tag instead of @user_agent ......................................................................
Using @custom-browser Cucumber tag instead of @user_agent Implementing the convention: https://www.mediawiki.org/wiki/Manual:Coding_conventions/Selenium#Option al_tags Bug: 61458 Change-Id: Iae1e40e04c0b993a45c1e46cd971c183b483bc70 --- M tests/browser/features/login_required_watchlist.feature M tests/browser/features/random_ua.feature M tests/browser/features/support/env.rb D tests/browser/features/support/hooks.rb 4 files changed, 2 insertions(+), 9 deletions(-) Approvals: Jdlrobson: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/login_required_watchlist.feature b/tests/browser/features/login_required_watchlist.feature index 8fec6d2..75c2ef1 100644 --- a/tests/browser/features/login_required_watchlist.feature +++ b/tests/browser/features/login_required_watchlist.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @test2.m.wikipedia.org @user_agent +@custom-browser @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @test2.m.wikipedia.org Feature: Login required for Watchlist Scenario: Login for Uploads @@ -6,5 +6,3 @@ When I select Watchlist Then I receive watchlist message A watchlist helps you bookmark pages and keep track of changes to them And I receive watchlist message Log in to see it. - - diff --git a/tests/browser/features/random_ua.feature b/tests/browser/features/random_ua.feature index 4f822d1..abbc7e5 100644 --- a/tests/browser/features/random_ua.feature +++ b/tests/browser/features/random_ua.feature @@ -1,4 +1,4 @@ [email protected] @en.m.wikipedia.org @test2.m.wikipedia.org @user_agent +@custom-browser @en.m.wikipedia.beta.wmflabs.org @en.m.wikipedia.org @test2.m.wikipedia.org Feature: Setting User Agents Scenario: Opera Mini diff --git a/tests/browser/features/support/env.rb b/tests/browser/features/support/env.rb index 108f7ae..fcb3706 100644 --- a/tests/browser/features/support/env.rb +++ b/tests/browser/features/support/env.rb @@ -1,4 +1,3 @@ -require_relative "hooks" require "mediawiki_selenium" def local_browser(user_agent) diff --git a/tests/browser/features/support/hooks.rb b/tests/browser/features/support/hooks.rb deleted file mode 100644 index 784542e..0000000 --- a/tests/browser/features/support/hooks.rb +++ /dev/null @@ -1,4 +0,0 @@ -Before("@user_agent") do |scenario| - @user_agent = true - @scenario = scenario -end \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/113776 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae1e40e04c0b993a45c1e46cd971c183b483bc70 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Zfilipin <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: JGonera <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Jhall <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
