Thiemo Mättig (WMDE) has uploaded a new change for review. https://gerrit.wikimedia.org/r/115885
Change subject: Fix Beta checkboxes not rendering in Opera 12 (Windows) ...................................................................... Fix Beta checkboxes not rendering in Opera 12 (Windows) This patch includes: * Simply replaced the SVG with a PNG (without actually deleting the SVG). Not all currently used browsers are able to use SVG as background images. They will simply show nothing in this case. Which is a blocker since the user haves no other hint (no color change, nothing) if a checkbox is checked or not. * Opera 12 (Windows) is able to render SVG as background image but does have a bug if such a SVG background is used in combination with border-radius. One way to fix this is to remove the radius and draw the border in SVG instead of CSS. An other is to simply use PNG. Since the BetaFeatures extension is actually using PNG in other places it can't be a problem to also use PNG here. * PNG files optimized *without* reducing the color depth (32 bit RGBA with alpha channel). This is actually important since not all combinations of bit depth, palette and transparency are rendered well in all browsers. * Background color set to white to make the checkboxes look a bit more like actual checkboxes. * CSS slightly optimized. These issues are discussed here: https://www.mediawiki.org/wiki/Talk:Beta_Features#Checkboxes Change-Id: I0cbec6f8473e633372daa32f9bc369ec403a0cf8 --- M css/betafeatures.css A img/form-icon/checked.png M img/form-icon/feature-information.png 3 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BetaFeatures refs/changes/85/115885/1 diff --git a/css/betafeatures.css b/css/betafeatures.css index 33b02bf..9c1146c 100644 --- a/css/betafeatures.css +++ b/css/betafeatures.css @@ -26,6 +26,7 @@ @charset "UTF-8"; /* line 102, sourcefiles/scss/components/default/_forms.scss */ .client-js .mw-ui-styled-checkbox-label { + background-color: #fff; cursor: pointer; display: inline-block; float: left; @@ -48,7 +49,7 @@ } /* line 117, sourcefiles/scss/components/default/_forms.scss */ .client-js .mw-ui-styled-checkbox-label.mw-ui-checked { - background: url("../img/form-icon/checked.svg") no-repeat; + background: #fff url("../img/form-icon/checked.png") no-repeat; } /* line 121, sourcefiles/scss/components/default/_forms.scss */ .client-js .mw-ui-styled-checkbox-label.mw-ui-disabled { @@ -62,7 +63,7 @@ /* line 132, sourcefiles/scss/components/default/_forms.scss */ table.mw-htmlform-container { border-collapse: separate; - border-spacing: 0px 4px; + border-spacing: 0 4px; } /* line 137, sourcefiles/scss/components/default/_forms.scss */ diff --git a/img/form-icon/checked.png b/img/form-icon/checked.png new file mode 100644 index 0000000..ce4e6b9 --- /dev/null +++ b/img/form-icon/checked.png Binary files differ diff --git a/img/form-icon/feature-information.png b/img/form-icon/feature-information.png index 1bd6ade..b251983 100644 --- a/img/form-icon/feature-information.png +++ b/img/form-icon/feature-information.png Binary files differ -- To view, visit https://gerrit.wikimedia.org/r/115885 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0cbec6f8473e633372daa32f9bc369ec403a0cf8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/BetaFeatures Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
