Thiemo Mättig (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/115893

Change subject: Typography refresh (VectorBeta extension) makes heading font to 
big
......................................................................

Typography refresh (VectorBeta extension) makes heading font to big

This is a temporary fix that needs to be revisited when the
VectorBeta extension is changed.

What does this patch do:
* Turn off the dramatically increased font size of the first
  heading.
* Reset font of the edit button next to the heading.
* Re-add missing margin between aliases and TOC.
* Remove a superfluous max-with. The outer .wb-entity container
  already sets the exact same max-width.
* I rewrote the TOC styles. Currently the second line of the TOC
  always starts with one of the gray lines. With my change the
  gray lines always stick to the end of the links.

Bug: 57436
Change-Id: I7714c727e6da9184fd52fe677d5a2d254a2dfa52
---
M lib/resources/wikibase.css
M repo/resources/themes/default/wikibase.toc.css
2 files changed, 26 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/93/115893/1

diff --git a/lib/resources/wikibase.css b/lib/resources/wikibase.css
index dca9911..16d1a93 100644
--- a/lib/resources/wikibase.css
+++ b/lib/resources/wikibase.css
@@ -99,11 +99,10 @@
 
 /* basically, a row in the grid layout */
 .wb-value-row {
-       width: 100%;
-       max-width: 65em;
-       position: relative; /* make absolute positioned toolbar align to the 
right edge */
-       font-size: 100%; /* font size needs to be set since it influences 
max-widh property */
        float: left; /* make row to take the dimensions of its containing 
blocks avoiding clipping */
+       font-size: 100%; /* font size needs to be set since it influences 
positioning */
+       position: relative; /* make absolute positioned toolbar align to the 
right edge */
+       width: 100%;
 }
 
 /* toolbar container */
@@ -231,6 +230,16 @@
        margin-bottom: 0; /* even out border of label container in view mode */
 }
 
+/* FIXME: Very specific selector to temporary overrule VectorBeta extension */
+#content .wb-firstHeading {
+       font-size: 100%;
+}
+
+/* FIXME: Very specific selector to temporary overrule VectorBeta extension */
+#content .wb-firstHeading .wb-editsection {
+       font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
+}
+
 /********** /LABEL **********/
 
 /********** DESCRIPTION **********/
diff --git a/repo/resources/themes/default/wikibase.toc.css 
b/repo/resources/themes/default/wikibase.toc.css
index 9afd333..b3e1bf5 100644
--- a/repo/resources/themes/default/wikibase.toc.css
+++ b/repo/resources/themes/default/wikibase.toc.css
@@ -3,6 +3,7 @@
  *
  * @licence GNU GPL v2+
  * @author H. Snater < mediaw...@snater.com >
+ * @author T. Mättig < thiemo.maet...@wikimedia.de >
  */
 
 .wb-entity #toc {
@@ -20,19 +21,23 @@
 
 .wb-entity #toc ul {
        float: left;
-       margin: 0;
-       padding: 0.4em 10px;
+       margin: 0 0 0 -.5em;
+       padding: .4em 10px;
 }
 
 .wb-entity #toc li {
-       border-left: 1px solid #c9c9c9;
+       border-right: 1px solid #c9c9c9;
        float: left;
-       margin-bottom: 0;
-       padding: 0 0.5em;
+       margin: 0;
+       padding: 0 .5em;
        white-space: nowrap;
 }
 
-.wb-entity #toc li:first-child {
-       border-left: none;
-       padding-left: 0;
+.wb-entity #toc li:last-child {
+       border-right: 0;
+}
+
+/* FIXME: Very specific selector to temporary overrule VectorBeta extension */
+#content .wb-entity #toc {
+       margin-top: 1.8em;
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/115893
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7714c727e6da9184fd52fe677d5a2d254a2dfa52
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to