Adamw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/116165
Change subject: Don't need to break the sqlite parser
......................................................................
Don't need to break the sqlite parser
One of the migrations will fail due to incompatible ALTER syntax--
fortunately, it isn't necessary anyway, cos we are building the schema
from scratch during unit testing.
Change-Id: I2e205ac074f75d0163f358dc2aa6652666b1741c
---
M ContributionTracking.php
1 file changed, 6 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContributionTracking
refs/changes/65/116165/1
diff --git a/ContributionTracking.php b/ContributionTracking.php
index 1412654..b39b8a1 100644
--- a/ContributionTracking.php
+++ b/ContributionTracking.php
@@ -131,10 +131,12 @@
$updater->addExtensionUpdate( array( 'addField',
'contribution_tracking', 'utm_key',
$dir . 'patches/patch-owa.sql', true ) );
- // Not sure how to do this in the other configurations,
but I guess
- // "manually" might be the answer.
- $updater->addExtensionUpdate( array( 'modifyField',
'contribution_tracking', 'anonymous',
- $dir . 'patches/make-null.patch.sql', true ) );
+ if ( $updater->getDB()->getType() !== 'sqlite' ) {
+ // Not sure how to do this in the other
configurations, but I guess
+ // "manually" might be the answer.
+ $updater->addExtensionUpdate( array(
'modifyField', 'contribution_tracking', 'anonymous',
+ $dir . 'patches/make-null.patch.sql',
true ) );
+ }
} else { //We are configured not to use the main mediawiki db.
//Unless the updater is modified not to run
//'LoadExtensionSchemaUpdates' hooks in its constructor
(or do so
--
To view, visit https://gerrit.wikimedia.org/r/116165
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e205ac074f75d0163f358dc2aa6652666b1741c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContributionTracking
Gerrit-Branch: master
Gerrit-Owner: Adamw <awi...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
