[MediaWiki-commits] [Gerrit] Only send zero-rated message for app if images also zero-rated. - change (mediawiki...ZeroRatedMobileAccess)

[Dr0ptp4kt (Code Review)]

Dr0ptp4kt has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/116189

Change subject: Only send zero-rated message for app if images also zero-rated.
......................................................................

Only send zero-rated message for app if images also zero-rated.

* Usually, person editing configuration will ensure images are on.
* But just in case images are not zero-rated, this accounts for that.

Change-Id: I2cf4bb5f8dcbdb009048f0512497ae64080dd825
---
M includes/ApiZeroConfig.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ZeroRatedMobileAccess 
refs/changes/89/116189/1

diff --git a/includes/ApiZeroConfig.php b/includes/ApiZeroConfig.php
index 03d571d..88d6266 100644
--- a/includes/ApiZeroConfig.php
+++ b/includes/ApiZeroConfig.php
@@ -82,7 +82,7 @@
                                }
                                $state = PageRenderingHooks::getState( $this );
                                $config = $state->getConfig();
-                               if ( $config !== null && 
!$config['disableApps'] ) {
+                               if ( $config !== null && 
!$config['disableApps'] && !$config['showImages'] ) {
                                        $result->addValue( $moduleName, 
'message', $state->getBannerText( $config, null, null ) );
                                } else {
                                        // json_encode will ultimately return 
as an empty array

-- 
To view, visit https://gerrit.wikimedia.org/r/116189
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cf4bb5f8dcbdb009048f0512497ae64080dd825
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ZeroRatedMobileAccess
Gerrit-Branch: master
Gerrit-Owner: Dr0ptp4kt <ab...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits