jenkins-bot has submitted this change and it was merged.
Change subject: Use template name as dialog title whenever possible
......................................................................
Use template name as dialog title whenever possible
Change-Id: I4235f6ed68e1f95c4593caa23ada734fb8493426
---
M VisualEditor.php
M modules/ve-mw/i18n/en.json
M modules/ve-mw/i18n/qqq.json
M modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
4 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/VisualEditor.php b/VisualEditor.php
index 9197fcb..fdf02aa 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -908,6 +908,7 @@
'ext.visualEditor.mwcore',
),
'messages' => array(
+ 'visualeditor-dialog-template-title',
'visualeditor-dialog-transclusion-add-content',
'visualeditor-dialog-transclusion-add-param',
'visualeditor-dialog-transclusion-add-template',
diff --git a/modules/ve-mw/i18n/en.json b/modules/ve-mw/i18n/en.json
index 847631f..916f985 100644
--- a/modules/ve-mw/i18n/en.json
+++ b/modules/ve-mw/i18n/en.json
@@ -107,6 +107,7 @@
"visualeditor-dialog-reference-title": "Reference",
"visualeditor-dialog-reference-useexisting-label": "Use an existing
reference",
"visualeditor-dialog-referencelist-title": "References list",
+ "visualeditor-dialog-template-title": "Template",
"visualeditor-dialog-transclusion-add-content": "Add content",
"visualeditor-dialog-transclusion-add-param": "Add parameter",
"visualeditor-dialog-transclusion-add-template": "Add template",
diff --git a/modules/ve-mw/i18n/qqq.json b/modules/ve-mw/i18n/qqq.json
index c319c34..7c7511d 100644
--- a/modules/ve-mw/i18n/qqq.json
+++ b/modules/ve-mw/i18n/qqq.json
@@ -112,6 +112,7 @@
"visualeditor-dialog-reference-title": "{{Identical|Reference}}",
"visualeditor-dialog-reference-useexisting-label": "Label for button in
reference dialog to insert a re-use of an existing reference",
"visualeditor-dialog-referencelist-title": "{{Identical|References list}}",
+ "visualeditor-dialog-template-title": "{{Identical|Template}}",
"visualeditor-dialog-transclusion-add-content": "Label for button that
adds parameter content to a transclusion.",
"visualeditor-dialog-transclusion-add-param": "Label for button that adds
parameter a parameter to a template.\n{{Identical|Add parameter}}",
"visualeditor-dialog-transclusion-add-template": "Label for button that
adds parameter a template to a transclusion.\n{{Identical|Add template}}",
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
index e32e322..cda4a72 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
@@ -63,6 +63,17 @@
} );
};
+/**
+ * @inheritdoc
+ */
+ve.ui.MWTemplateDialog.prototype.setup = function ( data ) {
+ // Parent method
+ ve.ui.MWTransclusionDialog.prototype.setup.call( this, data );
+
+ // Initialization
+ this.setTitle( ve.msg( 'visualeditor-dialog-template-title' ) );
+};
+
/* Registration */
ve.ui.dialogFactory.register( ve.ui.MWTemplateDialog );
--
To view, visit https://gerrit.wikimedia.org/r/116006
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4235f6ed68e1f95c4593caa23ada734fb8493426
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Trevor Parscal <tpars...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
