jenkins-bot has submitted this change and it was merged.

Change subject: Add tooltip to page options menu widget in the toolbar
......................................................................


Add tooltip to page options menu widget in the toolbar

Currently "Page options" but better suggestions are welcome.

Bug: 61892
Change-Id: I5cf7a4cabaaf7a5d5d0bd1b806f8d95ea4d88033
---
M VisualEditor.php
M modules/ve-mw/i18n/en.json
M modules/ve-mw/i18n/qqq.json
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
4 files changed, 6 insertions(+), 2 deletions(-)

Approvals:
  Catrope: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/VisualEditor.php b/VisualEditor.php
index 323434f..d9f9fd5 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -593,6 +593,7 @@
                        'visualeditor-help-title',
                        'visualeditor-mweditmodesource-title',
                        'visualeditor-mweditmodesource-warning',
+                       'visualeditor-pagemenu-tooltip',
                        'visualeditor-savedialog-error-badtoken',
                        'visualeditor-savedialog-label-create',
                        'visualeditor-savedialog-label-error',
diff --git a/modules/ve-mw/i18n/en.json b/modules/ve-mw/i18n/en.json
index 847631f..1947f08 100644
--- a/modules/ve-mw/i18n/en.json
+++ b/modules/ve-mw/i18n/en.json
@@ -159,6 +159,7 @@
     "visualeditor-notification-created": "\"$1\" has been created.",
     "visualeditor-notification-restored": "\"$1\" has been restored.",
     "visualeditor-notification-saved": "Your changes to \"$1\" have been 
saved.",
+    "visualeditor-pagemenu-tooltip": "Page options",
     "visualeditor-parameter-input-placeholder": "Parameter name",
     "visualeditor-parameter-search-no-unused": "No unused parameters",
     "visualeditor-parameter-search-unknown": "Unknown parameter",
diff --git a/modules/ve-mw/i18n/qqq.json b/modules/ve-mw/i18n/qqq.json
index c319c34..a4c7996 100644
--- a/modules/ve-mw/i18n/qqq.json
+++ b/modules/ve-mw/i18n/qqq.json
@@ -144,11 +144,11 @@
     "visualeditor-languageinspector-widget-changelang": "Used as label for the 
button which is used to change the language of the given block in the language 
inspector.\n{{Identical|Change language}}",
     "visualeditor-languages-tool": "Tool for opening the languages links 
section of the meta dialog.\n{{Identical|Language}}",
     "visualeditor-linkinspector-illegal-title": "Warning that the entered text 
is not a valid page title.",
+    "visualeditor-linkinspector-suggest-disambig-page": "Label for suggested 
disambiguation pages in the link inspector. Parameters:\n* $1 - number of 
disambiguation pages, used for plural\n{{Identical|Disambiguation page}}",
     "visualeditor-linkinspector-suggest-external-link": "Label for an external 
(Web) link in the link inspector.\n{{Identical|External link}}",
     "visualeditor-linkinspector-suggest-matching-page": "Label for suggested 
matching local wiki page or pages in the link inspector\nParams:\n* $1 - number 
of matching pages, used for plural",
-    "visualeditor-linkinspector-suggest-disambig-page": "Label for suggested 
disambiguation pages in the link inspector. Parameters:\n* $1 - number of 
disambiguation pages, used for plural\n{{Identical|Disambiguation page}}",
-    "visualeditor-linkinspector-suggest-redirect-page": "Label for suggested 
redirect pages in the link inspector. Parameters:\n* $1 - number of redirect 
pages, used for plural\n{{Identical|Redirect page}}",
     "visualeditor-linkinspector-suggest-new-page": "Label for a new page in 
the link inspector.\n{{Identical|New page}}",
+    "visualeditor-linkinspector-suggest-redirect-page": "Label for suggested 
redirect pages in the link inspector. Parameters:\n* $1 - number of redirect 
pages, used for plural\n{{Identical|Redirect page}}",
     "visualeditor-loadwarning": "Text (JavaScript confirm()) shown when the 
editor fails to load properly.\n\nParameters:\n* $1 - the error message from 
the server, in English. e.g. \"parsoidserver-http-bad-status: 404\"",
     "visualeditor-loadwarning-token": "Text (JavaScript confirm()) shown when 
the editor fails to load properly.\n\nParameters:\n* $1 - the error message 
from the server.",
     "visualeditor-mainnamespacepagelink": "Name of a page describing the main 
namespace (NS0) in this project.\n{{doc-important|Do not translate \"Project\"; 
it is automatically converted to the wiki's project namespace.}}",
@@ -164,6 +164,7 @@
     "visualeditor-notification-created": "Shown after a user creates a new 
page. Parameters:\n* $1 - a page name",
     "visualeditor-notification-restored": "Shown after a user restores a page 
to a previous revision. Parameters:\n* $1 is a page name.",
     "visualeditor-notification-saved": "Shown after a user saves a page. 
Parameters:\n* $1 - a page name",
+    "visualeditor-pagemenu-tooltip": "Tooltip text for the page menu which has 
the following items:\n* {{msg-mw|visualeditor-meta-tool}}\n* 
{{msg-mw|visualeditor-settings-tool}}\n* 
{{msg-mw|visualeditor-advancedsettings-tool}}\n* 
{{msg-mw|visualeditor-categories-tool}}\n* 
{{msg-mw|visualeditor-languages-tool}}\n* 
{{msg-mw|visualeditor-mweditmodesource-title}}\n* 
{{msg-mw|visualeditor-dialog-commmand-help-title}}",
     "visualeditor-parameter-input-placeholder": "Placeholder text label for an 
input for adding a parameter to a template.\n{{Identical|Parameter name}}",
     "visualeditor-parameter-search-no-unused": "Message displayed in the 
transclusion dialog when no known parameters are unused by this template.",
     "visualeditor-parameter-search-unknown": "{{Identical|Unknown parameter}}",
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js 
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index c90724d..80e0489 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -1053,6 +1053,7 @@
                {
                        'type': 'list',
                        'icon': 'menu',
+                       'title': ve.msg( 'visualeditor-pagemenu-tooltip' ),
                        'include': [ 'meta', 'settings', 'advancedSettings', 
'categories', 'languages', 'editModeSource', 'commandHelp' ]
                }
        ] );

-- 
To view, visit https://gerrit.wikimedia.org/r/116145
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5cf7a4cabaaf7a5d5d0bd1b806f8d95ea4d88033
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to