Brion VIBBER has submitted this change and it was merged.
Change subject: Revert "Cleanup webviews when we no longer require them"
......................................................................
Revert "Cleanup webviews when we no longer require them"
Was causing crashes when back button was pressed. Needs
a better longer term memory management solution instead.
This reverts commit 488bece3e5fd6985822ec7b404ade1cf16f3bc36.
Change-Id: I54503cac5640eeaaf3e5658ae3b2bbe35175dac0
---
M wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
index c8da5b7..8b0552f 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageViewFragment.java
@@ -327,10 +327,4 @@
}
return false;
}
-
- @Override
- public void onDestroyView() {
- super.onDestroyView();
- webView.destroy();
- }
}
--
To view, visit https://gerrit.wikimedia.org/r/116752
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54503cac5640eeaaf3e5658ae3b2bbe35175dac0
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
