Zfilipin has uploaded a new change for review.
https://gerrit.wikimedia.org/r/117180
Change subject: Fixed login method, instead of waiting for link with text in
English, wait for link with href
......................................................................
Fixed login method, instead of waiting for link with text in English, wait for
link with href
Paired with Amir Aharoni.
Longer error message: timed out after 5 seconds, waiting for
{:text=>"Log out", :tag_name=>"a"} to become present
(Watir::Wait::TimeoutError)
Example job:
https://wmf.ci.cloudbees.com/view/uls/job/UniversalLanguageSelector-lang
uage-browsertests.wmflabs.org-linux-firefox/lastCompletedBuild/testRepor
t/(root)/Font%20selection/Font_selector_pane_appears/
Change-Id: I722b90272b1f3c56fc0a46b920212f79a37fdb8a
---
M lib/mediawiki_selenium/support/pages/login_page.rb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/selenium
refs/changes/80/117180/1
diff --git a/lib/mediawiki_selenium/support/pages/login_page.rb
b/lib/mediawiki_selenium/support/pages/login_page.rb
index ce8b615..425ac41 100644
--- a/lib/mediawiki_selenium/support/pages/login_page.rb
+++ b/lib/mediawiki_selenium/support/pages/login_page.rb
@@ -17,7 +17,7 @@
div(:feedback, class: "errorbox")
button(:login, id: "wpLoginAttempt")
- a(:logout_link, text: "Log out")
+ a(:logout, href: /Special:UserLogout/)
text_field(:password, id: "wpPassword1")
a(:password_strength, text: "password strength")
a(:phishing, text: "phishing")
@@ -32,6 +32,6 @@
self.password_element.when_present.send_keys(password)
login_element.fire_event("onfocus")
login_element.when_present.click
- logout_link_element.when_present
+ logout_element.when_present
end
end
--
To view, visit https://gerrit.wikimedia.org/r/117180
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I722b90272b1f3c56fc0a46b920212f79a37fdb8a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/selenium
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
