Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/117228
Change subject: mw.ViewPageTarget: Check elementsThatHadOurAccessKey before
accessing
......................................................................
mw.ViewPageTarget: Check elementsThatHadOurAccessKey before accessing
Follows-up I31d6b9ea065b3be85ed0.
Bug: 62329
Change-Id: I83a6f20cafd6193d64142914f72c1496d03294a5
(cherry picked from commit 8735ea2ef9bcd1325ead46ad83197ae3b3469e3c)
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/28/117228/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 80e0489..6185a3c 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -226,7 +226,7 @@
) {
this.deactivating = true;
// User interface changes
- if ( ve.msg( 'accesskey-save' ) !== '-' && ve.msg(
'accesskey-save' ) !== '' ) {
+ if ( this.elementsThatHadOurAccessKey ) {
this.elementsThatHadOurAccessKey.attr(
'accesskey', ve.msg( 'accesskey-save' ) );
}
this.restorePage();
--
To view, visit https://gerrit.wikimedia.org/r/117228
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I83a6f20cafd6193d64142914f72c1496d03294a5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.23wmf17
Gerrit-Owner: Alex Monk <kren...@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
