jenkins-bot has submitted this change and it was merged.
Change subject: Use mediawiki.ui.button instead of mediawiki.ui
......................................................................
Use mediawiki.ui.button instead of mediawiki.ui
* 9e4e58bce8d10f65cf298b39f48e86c41b6a82b8 separated mediawiki.ui.button
into a separate module (for modularity, and potentially to allow
wiki content to use mw.ui buttons by default in the future).
* Currently, the button code is in both mediawiki.ui and
mediawiki.ui.button for backwards compatibility. However, it will be
removed from mediawiki.ui when existing uses transition over; see
I5bd23434961497d49293956c92b46ab3a6f14a41 .
* ContentTranslation does not use any core mw.ui features other than
buttons. If it does in the future, 'mediawiki.ui' can be added.
* Some 'mediawiki.ui.button' uses must work without JS, so they have
to use addModuleStyles. Thus, the best practice is for all to do so
when possible to avoid double-loading.
Change-Id: I2e1f894517d5e558099590dd72907b958dcd83ad
---
M Resources.php
M specials/SpecialContentTranslation.php
2 files changed, 1 insertion(+), 1 deletion(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/Resources.php b/Resources.php
index d1888f9..c0dbd22 100644
--- a/Resources.php
+++ b/Resources.php
@@ -29,7 +29,6 @@
'base/styles/ext.cx.base.less',
),
'dependencies' => array(
- 'mediawiki.ui',
'ext.cx.model',
'ext.cx.header',
'ext.cx.source',
diff --git a/specials/SpecialContentTranslation.php
b/specials/SpecialContentTranslation.php
index 9375931..53382d5 100644
--- a/specials/SpecialContentTranslation.php
+++ b/specials/SpecialContentTranslation.php
@@ -31,6 +31,7 @@
if ( !($user->isLoggedIn() ) ) {
$out->addHTML( $this->msg( 'cx-special-login-error' ) );
} else {
+ $out->addModuleStyles( 'mediawiki.ui.button' );
$out->addModules( 'ext.cx.base' );
$this->setHeaders();
$out->setArticleBodyOnly( true );
--
To view, visit https://gerrit.wikimedia.org/r/115526
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e1f894517d5e558099590dd72907b958dcd83ad
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: KartikMistry <kartik.mis...@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
