jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Wrap QA arguments in quotes to match other test coding
conventions
......................................................................
Hygiene: Wrap QA arguments in quotes to match other test coding conventions
Change-Id: I771d4384f5229a6e37489b220a5d131ffe6966b6
---
M tests/browser/features/diff.feature
M tests/browser/features/editor_ve.feature
M tests/browser/features/keepgoing.feature
M tests/browser/features/step_definitions/common_article_steps.rb
4 files changed, 7 insertions(+), 7 deletions(-)
Approvals:
Kaldari: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/diff.feature
b/tests/browser/features/diff.feature
index d28e189..e854e61 100644
--- a/tests/browser/features/diff.feature
+++ b/tests/browser/features/diff.feature
@@ -6,12 +6,12 @@
When I go to the "Diff test" page
And I click the edit button
And I clear the editor
- And I type ABC DEF into the editor
+ And I type "ABC DEF" into the editor
And I click continue
And I click submit
And I click the edit button
And I clear the editor
- And I type ABC GHI into the editor
+ And I type "ABC GHI" into the editor
And I click continue
And I click submit
And I click on the view edit history link
diff --git a/tests/browser/features/editor_ve.feature
b/tests/browser/features/editor_ve.feature
index b91b6d8..07e3ed3 100644
--- a/tests/browser/features/editor_ve.feature
+++ b/tests/browser/features/editor_ve.feature
@@ -17,7 +17,7 @@
When I am on the Selenium Edit Test article
And I click the edit button
And VisualEditor has loaded
- And I type ABCDEFG into VisualEditor
+ And I type "ABCDEFG" into VisualEditor
And I click continue
And I click submit
Then I see a toast confirmation
@@ -27,7 +27,7 @@
And I am logged into the mobile website
When I am on the Selenium Edit Test article
And I click the edit button
- And I type ABCDEFG into VisualEditor
+ And I type "ABCDEFG" into VisualEditor
And I click continue
And I click the escape button
Then I see the VisualEditor
diff --git a/tests/browser/features/keepgoing.feature
b/tests/browser/features/keepgoing.feature
index 5274c72..7c4c929 100644
--- a/tests/browser/features/keepgoing.feature
+++ b/tests/browser/features/keepgoing.feature
@@ -7,7 +7,7 @@
And I have just registered a new account
When I am on the Selenium Edit Test article
And I click the edit button
- And I type ABCDEFG into the editor
+ And I type "ABCDEFG" into the editor
And I click continue
And I click submit
Then I see the KeepGoing drawer prompting me to continue editing
diff --git a/tests/browser/features/step_definitions/common_article_steps.rb
b/tests/browser/features/step_definitions/common_article_steps.rb
index 7e4e29b..964297d 100644
--- a/tests/browser/features/step_definitions/common_article_steps.rb
+++ b/tests/browser/features/step_definitions/common_article_steps.rb
@@ -14,7 +14,7 @@
on(ArticlePage).editor_ve_element.when_present.should exist
end
-Given(/^I type (.+) into the editor$/) do |text|
+Given(/^I type "(.+)" into the editor$/) do |text|
on(ArticlePage).editor_text_area_element.when_present.send_keys(text)
end
@@ -34,7 +34,7 @@
on(ArticlePage).overlay_ve_header_toolbar_italic_button_element.when_present.should
exist
end
-Given(/^I type (.+) into VisualEditor$/) do |text|
+Given(/^I type "(.+)" into VisualEditor$/) do |text|
on(ArticlePage) do |page|
page.editor_ve_element.when_present(15).fire_event("onfocus")
page.editor_ve_element.when_present.send_keys(text)
--
To view, visit https://gerrit.wikimedia.org/r/116911
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I771d4384f5229a6e37489b220a5d131ffe6966b6
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
