Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/117672
Change subject: ResourceLoader::makeLoaderImplementScript: bind args as '$' &
'jQuery'
......................................................................
ResourceLoader::makeLoaderImplementScript: bind args as '$' & 'jQuery'
Make the function that wraps ResourceLoader modules bind the first and second
arguments it receives to '$' and 'jQuery'. This patch is a follow-up to change
I0c9edac35, which updated the invocation of mw.loader#implement so that it
passes jQuery as the first and second argument.
Change-Id: I0f0c3a04c3b0e6a28115a10bf11a2a78aca66c21
---
M includes/resourceloader/ResourceLoader.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/72/117672/1
diff --git a/includes/resourceloader/ResourceLoader.php
b/includes/resourceloader/ResourceLoader.php
index 557c1f6..b442a3d 100644
--- a/includes/resourceloader/ResourceLoader.php
+++ b/includes/resourceloader/ResourceLoader.php
@@ -903,7 +903,7 @@
*/
public static function makeLoaderImplementScript( $name, $scripts,
$styles, $messages ) {
if ( is_string( $scripts ) ) {
- $scripts = new XmlJsCode( "function ()
{\n{$scripts}\n}" );
+ $scripts = new XmlJsCode( "function ( $, jQuery )
{\n{$scripts}\n}" );
} elseif ( !is_array( $scripts ) ) {
throw new MWException( 'Invalid scripts error. Array of
URLs or string of code expected.' );
}
--
To view, visit https://gerrit.wikimedia.org/r/117672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f0c3a04c3b0e6a28115a10bf11a2a78aca66c21
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
