Addshore has submitted this change and it was merged. Change subject: add visibility to SerializerFactory constructor ......................................................................
add visibility to SerializerFactory constructor (this class shall be deleted soonish, but until then fix this) Change-Id: I25ee118eab90c1f98d295f2cba12b1db3005898c --- M lib/includes/serializers/SerializerFactory.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: WikidataJenkins: Verified Addshore: Looks good to me, approved diff --git a/lib/includes/serializers/SerializerFactory.php b/lib/includes/serializers/SerializerFactory.php index f6a9cc6..cc05596 100644 --- a/lib/includes/serializers/SerializerFactory.php +++ b/lib/includes/serializers/SerializerFactory.php @@ -50,7 +50,7 @@ * * @todo: injecting the services should be required */ - function __construct( + public function __construct( SerializationOptions $defaultOptions = null, PropertyDataTypeLookup $dataTypeLookup = null, EntityFactory $entityFactory = null, -- To view, visit https://gerrit.wikimedia.org/r/117886 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25ee118eab90c1f98d295f2cba12b1db3005898c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits