Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/118618
Change subject: Check for deleted revision in ContentRetriever
......................................................................
Check for deleted revision in ContentRetriever
Bug: 62545
Change-Id: I65de68149b69347fb4a9e822bd970b24cd95e232
(cherry picked from commit 0a4986ccfd48422ca96166e0390e864946353ffc)
---
M repo/includes/ContentRetriever.php
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/18/118618/1
diff --git a/repo/includes/ContentRetriever.php
b/repo/includes/ContentRetriever.php
index 5ca5495..173d36a 100644
--- a/repo/includes/ContentRetriever.php
+++ b/repo/includes/ContentRetriever.php
@@ -38,6 +38,11 @@
public function getContentForRequest( WebRequest $request, Article
$article ) {
$revision = $article->getRevisionFetched();
+ // check for delete or unavailable revision
+ if ( !$revision ) {
+ return null;
+ }
+
if ( $request->getCheck( 'diff' ) ) {
$oldId = $revision->getId();
$diffValue = $request->getVal( 'diff' );
--
To view, visit https://gerrit.wikimedia.org/r/118618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65de68149b69347fb4a9e822bd970b24cd95e232
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.23-wmf17
Gerrit-Owner: Hoo man <h...@online.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
