jenkins-bot has submitted this change and it was merged. Change subject: QA Needs a when_present for slow browsers ......................................................................
QA Needs a when_present for slow browsers Change-Id: I9f5485c0c96c99954cf53db9c7c5a76b39aff607 --- M tests/browser/features/step_definitions/search_steps.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/browser/features/step_definitions/search_steps.rb b/tests/browser/features/step_definitions/search_steps.rb index 41e62a4..5586737 100644 --- a/tests/browser/features/step_definitions/search_steps.rb +++ b/tests/browser/features/step_definitions/search_steps.rb @@ -1,5 +1,5 @@ Then(/^I see the search button$/) do - on(ArticlePage).search_button_element.should be_visible + on(ArticlePage).search_button_element.when_present.should be_visible end When(/^I click the placeholder search box$/) do -- To view, visit https://gerrit.wikimedia.org/r/118710 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f5485c0c96c99954cf53db9c7c5a76b39aff607 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org> Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
