Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/118732

Change subject: mediawiki.api.category: getCategories: Deprecate the 'async' 
parameter
......................................................................

mediawiki.api.category: getCategories: Deprecate the 'async' parameter

One should never set it to anything other than the default value.

Change-Id: I6d191916f14aa29a04b2190debe9901032629938
---
M resources/mediawiki.api/mediawiki.api.category.js
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/32/118732/1

diff --git a/resources/mediawiki.api/mediawiki.api.category.js 
b/resources/mediawiki.api/mediawiki.api.category.js
index 2f717ea..4859ce2 100644
--- a/resources/mediawiki.api/mediawiki.api.category.js
+++ b/resources/mediawiki.api/mediawiki.api.category.js
@@ -91,7 +91,7 @@
                 * @param {mw.Title} title
                 * @param {Function} [ok] Success callback (deprecated)
                 * @param {Function} [err] Error callback (deprecated)
-                * @param {boolean} [async=true] Asynchronousness
+                * @param {boolean} [async=true] Asynchronousness (deprecated)
                 * @return {jQuery.Promise}
                 * @return {Function} return.done
                 * @return {boolean|mw.Title[]} return.done.categories List of 
category titles or false
@@ -110,6 +110,11 @@
                                mw.track( 'mw.deprecate', 'api.cbParam' );
                                mw.log.warn( msg );
                        }
+                       // Backwards compatibility (< MW 1.23)
+                       if ( async !== undefined ) {
+                               mw.track( 'mw.deprecate', 'api.async' );
+                               mw.log.warn( 'Use of mediawiki.api async params 
is deprecated' );
+                       }
 
                        return apiPromise
                                .then( function ( data ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/118732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d191916f14aa29a04b2190debe9901032629938
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to