[MediaWiki-commits] [Gerrit] Add 'Send app feedback' to iOS app. - change (apps...wikipedia)

[Brion VIBBER (Code Review)]

Brion VIBBER has submitted this change and it was merged.

Change subject: Add 'Send app feedback' to iOS app.
......................................................................


Add 'Send app feedback' to iOS app.

* For now, just emails mhurd and subject contains version.

Change-Id: I39bc57131bd2ead3fd2dccbb220217f72d75af3c
---
M Wikipedia-iOS/View Controllers/MainMenu/MainMenuTableViewController.m
M Wikipedia-iOS/en.lproj/Localizable.strings
M Wikipedia-iOS/qqq.lproj/Localizable.strings
3 files changed, 25 insertions(+), 1 deletion(-)

Approvals:
  Brion VIBBER: Verified; Looks good to me, approved



diff --git a/Wikipedia-iOS/View 
Controllers/MainMenu/MainMenuTableViewController.m b/Wikipedia-iOS/View 
Controllers/MainMenu/MainMenuTableViewController.m
index 7ab2fe8..ffec760 100644
--- a/Wikipedia-iOS/View Controllers/MainMenu/MainMenuTableViewController.m
+++ b/Wikipedia-iOS/View Controllers/MainMenu/MainMenuTableViewController.m
@@ -11,6 +11,7 @@
 #import "SessionSingleton.h"
 #import "WebViewController.h"
 #import "UINavigationController+SearchNavStack.h"
+#import "WikipediaAppUtils.h"
 
 // Section indexes.
 #define SECTION_LOGIN_OPTIONS 0
@@ -288,6 +289,20 @@
                                                } mutableCopy]
                                            ] mutableCopy]
                                } mutableCopy]
+                            ,
+                            [@{
+                               @"key": @"sendFeedbackHeading",
+                               @"title": 
NSLocalizedString(@"main-menu-feedback-heading", nil),
+                               @"label": @"",
+                               @"subTitle": @"",
+                               @"rows": [@[
+                                           [@{
+                                              @"key": @"sendFeedback",
+                                              @"title": 
NSLocalizedString(@"main-menu-send-feedback", nil),
+                                              @"label": @""
+                                              } mutableCopy]
+                                           ] mutableCopy]
+                               } mutableCopy]
                             ] mutableCopy];
 }
 
@@ -507,11 +522,16 @@
         [[SessionSingleton sharedInstance].zeroConfigState toggleDevMode];
         [self updateZeroToggles];
         [self.tableView reloadData];
-    }  else if ([selectedRowKey isEqualToString:@"randomTappable"]) {
+    } else if ([selectedRowKey isEqualToString:@"randomTappable"]) {
         [tableView deselectRowAtIndexPath:indexPath animated:YES];
         // TODO: make showAlert work. mhurd on it.
         // [self showAlert:NSLocalizedString(@"fetching-random-article", nil)];
         [self fetchRandomArticle];
+    } else if ([selectedRowKey isEqualToString:@"sendFeedback"]) {
+        [tableView deselectRowAtIndexPath:indexPath animated:YES];
+        NSString *mailtoUri = [NSString 
stringWithFormat:@"mailto:mh...@wikimedia.org?subject=Feedback:%@";,
+                               [WikipediaAppUtils appVersion]];
+        [[UIApplication sharedApplication] openURL:[NSURL 
URLWithString:mailtoUri]];
     }
 }
 
diff --git a/Wikipedia-iOS/en.lproj/Localizable.strings 
b/Wikipedia-iOS/en.lproj/Localizable.strings
index 29317c8..8af3bb8 100644
--- a/Wikipedia-iOS/en.lproj/Localizable.strings
+++ b/Wikipedia-iOS/en.lproj/Localizable.strings
@@ -65,6 +65,8 @@
 "main-menu-show-saved" = "My saved pages";
 "main-menu-current-article-save" = "Save for offline reading";
 "main-menu-random" = "Random";
+"main-menu-feedback-heading" = "App feedback";
+"main-menu-send-feedback" = "Send app feedback";
 
 "saved-pages-title" = "Saved Pages";
 
diff --git a/Wikipedia-iOS/qqq.lproj/Localizable.strings 
b/Wikipedia-iOS/qqq.lproj/Localizable.strings
index 7e1a7b6..53c3740 100644
--- a/Wikipedia-iOS/qqq.lproj/Localizable.strings
+++ b/Wikipedia-iOS/qqq.lproj/Localizable.strings
@@ -62,6 +62,8 @@
 "main-menu-show-saved" = "Button text for saved articles interface";
 "main-menu-current-article-save" = "Button text for saving the current 
article";
 "main-menu-random" = "Button text for fetching a Random article";
+"main-menu-feedback-heading" = "Header text for app feedback";
+"main-menu-send-feedback" = "Button text for button to send app feedback";
 "saved-pages-title" = "Header text for Saved Pages interface";
 "navbar-title-mode-edit-wikitext" = "Header text shown when wikitext is being 
edited";
 "navbar-title-mode-login" = "Header text shown when user is signing in";

-- 
To view, visit https://gerrit.wikimedia.org/r/118633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39bc57131bd2ead3fd2dccbb220217f72d75af3c
Gerrit-PatchSet: 4
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dr0ptp4kt <ab...@wikimedia.org>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Mhurd <mh...@wikimedia.org>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits