Nikerabbit has uploaded a new change for review. https://gerrit.wikimedia.org/r/118814
Change subject: Micro-optimization for MessageGroups::haveSingleSourceLanguage ...................................................................... Micro-optimization for MessageGroups::haveSingleSourceLanguage The new algorithm scales linearly Change-Id: I36f0432fd83e80ae60101bf90a5fcc01d693e714 --- M MessageGroups.php 1 file changed, 6 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/14/118814/1 diff --git a/MessageGroups.php b/MessageGroups.php index da5db47..e597080 100644 --- a/MessageGroups.php +++ b/MessageGroups.php @@ -636,20 +636,18 @@ * @since 2013.09 */ public static function haveSingleSourceLanguage( array $groups ) { - $languages = array(); + $seen = ''; foreach ( $groups as $group ) { $language = $group->getSourceLanguage(); - if ( !in_array( $language, $languages ) ) { - $languages[] = $language; + if ( $seen === '' ) { + $language = $seen; + } elseif ( $language !== $seen ) { + return ''; } } - if ( count( $languages ) === 1 ) { - return $languages[0]; - } - - return ''; + return $seen; } /** -- To view, visit https://gerrit.wikimedia.org/r/118814 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I36f0432fd83e80ae60101bf90a5fcc01d693e714 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits