[MediaWiki-commits] [Gerrit] Don't redraw headings - change (mediawiki...Wikibase)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Don't redraw headings
......................................................................


Don't redraw headings

This is a prerequisite for bug 62527.

Change-Id: I0a202a2273b77fb03c62d21337f3869993712afe
---
M lib/resources/Resources.php
M lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
M repo/resources/wikibase.ui.entityViewInit.js
3 files changed, 3 insertions(+), 11 deletions(-)

Approvals:
  Hoo man: Looks good to me, approved
  WikidataJenkins: Verified
  jenkins-bot: Verified



diff --git a/lib/resources/Resources.php b/lib/resources/Resources.php
index 0c34c22..96b254b 100644
--- a/lib/resources/Resources.php
+++ b/lib/resources/Resources.php
@@ -817,7 +817,6 @@
                                'jquery.wikibase.claimlistview',
                                'jquery.wikibase.claimgrouplistview',
                                'jquery.wikibase.toolbarcontroller',
-                               'wikibase.templates'
                        )
                ),
 
diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js 
b/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
index 89cd20d..a329692 100644
--- a/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
+++ b/lib/resources/jquery.wikibase/jquery.wikibase.entityview.js
@@ -2,7 +2,7 @@
  * @licence GNU GPL v2+
  * @author Daniel Werner < daniel.wer...@wikimedia.de >
  */
-( function( mw, wb, $ ) {
+( function( wb, $ ) {
        'use strict';
 
 /**
@@ -42,11 +42,7 @@
        _create: function() {
                this.element.empty();
 
-               var entity = this.option( 'value' ),
-                       $claimsHeading =
-                               $( mw.template( 'wb-section-heading', mw.msg( 
'wikibase-statements' ), '' ) );
-
-               this.element.append( $claimsHeading );
+               var entity = this.option( 'value' );
 
                this.$claims = $( '<div/>' ).appendTo( this.element 
).claimgrouplistview( {
                        value: entity.getClaims(),
@@ -178,4 +174,4 @@
        }
 } );
 
-}( mediaWiki, wikibase, jQuery ) );
+}( wikibase, jQuery ) );
diff --git a/repo/resources/wikibase.ui.entityViewInit.js 
b/repo/resources/wikibase.ui.entityViewInit.js
index af764c8..bba8d47 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -76,9 +76,6 @@
                                new wb.ui.AliasesEditTool( this );
                        } );
 
-                       // remove all the headings except the site link section 
headings
-                       $( '.wb-section-heading' ).not( '.wb-sitelinks-heading' 
).remove();
-
                        // BUILD CLAIMS VIEW:
                        // Note: $.entityview() only works for claims right 
now, the goal is to use it for more
                        var $claims = $( '.wb-claims' ).first(),

-- 
To view, visit https://gerrit.wikimedia.org/r/118672
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0a202a2273b77fb03c62d21337f3869993712afe
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <adrian.l...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits