Amire80 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/119025
Change subject: Simplify tofu detection cache
......................................................................
Simplify tofu detection cache
Change-Id: If68fce9c0bd281019de6e2992c856bdbe843aec8
---
M resources/js/ext.uls.webfonts.js
1 file changed, 6 insertions(+), 8 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector
refs/changes/25/119025/1
diff --git a/resources/js/ext.uls.webfonts.js b/resources/js/ext.uls.webfonts.js
index a1e3bd4..96a9af9 100644
--- a/resources/js/ext.uls.webfonts.js
+++ b/resources/js/ext.uls.webfonts.js
@@ -142,7 +142,7 @@
* @param {array} classes
*/
fontSelector: function ( repository, language, classes
) {
- var font, tofu, autonym, defaultFont;
+ var font, autonym, defaultFont;
if ( !language ) {
return null;
@@ -164,19 +164,17 @@
// There is a default font for this
language,
// but check whether the user sees tofu
for it.
- tofu = tofuLanguages[language] ||
- detectTofu(
$.uls.data.getAutonym( language ) );
+ if ( tofuLanguages[language] ===
undefined ) {
+ tofuLanguages[language] =
detectTofu( $.uls.data.getAutonym( language ) );
- if ( tofu ) {
// Log the tofu detection only
once per page per language
- if ( !tofuLanguages[language] )
{
+ if ( tofuLanguages[language] ) {
mw.log( 'tofu detected
for ' + language );
mw.hook(
'mw.uls.webfonts.tofudetected' ).fire( language );
-
- // Cache the languages
with tofu
- tofuLanguages[language]
= true;
}
+ }
+ if ( tofuLanguages[language] ) {
font = autonym ? 'Autonym' :
defaultFont;
} else {
// No tofu and no font
preference. Use system font.
--
To view, visit https://gerrit.wikimedia.org/r/119025
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If68fce9c0bd281019de6e2992c856bdbe843aec8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
