Manybubbles has uploaded a new change for review.
https://gerrit.wikimedia.org/r/119064
Change subject: Avoid infinite fallback loops
......................................................................
Avoid infinite fallback loops
Follow-up to I144dacaf36
Change-Id: I72868fb866c53388bb839990b0bb303358410126
---
M includes/AnalysisConfigBuilder.php
1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CirrusSearch
refs/changes/64/119064/1
diff --git a/includes/AnalysisConfigBuilder.php
b/includes/AnalysisConfigBuilder.php
index d74d2da..6a24d8f 100644
--- a/includes/AnalysisConfigBuilder.php
+++ b/includes/AnalysisConfigBuilder.php
@@ -206,13 +206,12 @@
return $this->elasticsearchLanguageAnalyzers[
$this->language ];
}
- // Try the fallback chain, unless we hit english
- $code = Language::getFallbackFor( $this->language );
- while ( $code && $code != 'en' ) {
- if ( array_key_exists( $code,
$this->elasticsearchLanguageAnalyzers ) ) {
+ // Try the fallback chain, excluding English
+ $languages = Language::getFallbacksFor( $this->language );
+ foreach ( $languages as $code ) {
+ if ( $code !== 'en' && array_key_exists( $code,
$this->elasticsearchLanguageAnalyzers ) ) {
return $this->elasticsearchLanguageAnalyzers[
$code ];
}
- $code = Language::getFallbackFor( $code );
}
return 'default';
--
To view, visit https://gerrit.wikimedia.org/r/119064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I72868fb866c53388bb839990b0bb303358410126
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: wmf/1.23wmf18
Gerrit-Owner: Manybubbles <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
