Daniel Friesen has submitted this change and it was merged. Change subject: Fix jump links. ......................................................................
Fix jump links. - To work, jump links must be at the top, with almost no content above them. - MW used "jump" to refer to it's "Jump to navigation", for "... to content" it's typically good to use "Skip" instead of "Jump" since these were originally called "Skip links" - i18n keys should also be prefixed. - Jump links should not be display: none; Screen readers nowadays use standard browsers, not text browsers. So using display: none; essentially disables jump links entirely. You also want them to be visible on-focus because these links are used by users with motor disabilities in addition to just blind users. Change-Id: I828dedc735c55119b9693c36c809d3fcb4441d92 --- M Erudite.i18n.php M Erudite.skin.php M assets/wiki-style.css 3 files changed, 18 insertions(+), 9 deletions(-) Approvals: Daniel Friesen: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/25021 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I828dedc735c55119b9693c36c809d3fcb4441d92 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/erudite Gerrit-Branch: master Gerrit-Owner: Daniel Friesen <[email protected]> Gerrit-Reviewer: Daniel Friesen <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
