GWicke has submitted this change and it was merged. Change subject: Fixed bug in template encapsulation code. ......................................................................
Fixed bug in template encapsulation code. * Template info should not be added to the first token of a chunk since the info can get lost during later passes (ex: li tokens). With this fix, a meta-tag is always added when a non-string token is encountered as the first tag. * This bug was exposed when I messed with the peg tokenizer to return bigger token chunks whenever possible. * No changes in parser tests coverage. Unrelated changes: * JSHint fixes in TemplateHandler. * comment fixes in wikitext serializer Change-Id: Id08e93486aba6a4d7b6daece44b9ec03b40b738f --- M js/lib/ext.core.TemplateHandler.js M js/lib/mediawiki.WikitextSerializer.js 2 files changed, 46 insertions(+), 54 deletions(-) Approvals: GWicke: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/25027 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id08e93486aba6a4d7b6daece44b9ec03b40b738f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry <[email protected]> Gerrit-Reviewer: GWicke <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
