Brion VIBBER has submitted this change and it was merged.
Change subject: Get rid of share lead text
......................................................................
Get rid of share lead text
We shouldn't add random extra boilerplate to what someone is sharing.
Besides, we don't need the advertisement :D
Change-Id: Ie80eb4da581cfdb90085dc8b962f27c3099c4af4
---
M wikipedia/res/values/strings.xml
M wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
2 files changed, 1 insertion(+), 3 deletions(-)
Approvals:
Brion VIBBER: Verified; Looks good to me, approved
diff --git a/wikipedia/res/values/strings.xml b/wikipedia/res/values/strings.xml
index cb1b574..e83cd81 100644
--- a/wikipedia/res/values/strings.xml
+++ b/wikipedia/res/values/strings.xml
@@ -24,7 +24,6 @@
<string name="menu_save_page">Save page</string>
<string name="menu_share_page">Share</string>
<string name="share_via">Share via</string>
- <string name="share_lead_in_text">Found with Wikipedia App:</string>
<string name="dialog_title_clear_saved_pages">Clear saved pages?</string>
<string name="dialog_message_clear_saved_pages">Are you sure you want to
clear all saved pages?</string>
<string name="toast_saving_page">Saving page...</string>
diff --git a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
index feb5155..536cf81 100644
--- a/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/wikipedia/src/main/java/org/wikipedia/page/PageActivity.java
@@ -108,8 +108,7 @@
public void onSharePageEvent(SharePageEvent event) {
Intent shareIntent = new Intent();
shareIntent.setAction(Intent.ACTION_SEND);
- shareIntent.putExtra(Intent.EXTRA_TEXT,
getResources().getString(R.string.share_lead_in_text) +
- " " + curPageFragment.getTitle().getDisplayText() + " " +
curPageFragment.getTitle().getCanonicalUri());
+ shareIntent.putExtra(Intent.EXTRA_TEXT,
curPageFragment.getTitle().getDisplayText() + " " +
curPageFragment.getTitle().getCanonicalUri());
shareIntent.setType("text/plain");
Intent chooser = Intent.createChooser(shareIntent,
getResources().getString(R.string.share_via));
startActivity(chooser);
--
To view, visit https://gerrit.wikimedia.org/r/119240
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie80eb4da581cfdb90085dc8b962f27c3099c4af4
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <yuvipa...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
