jenkins-bot has submitted this change and it was merged. Change subject: Don't launch in articles with no text ......................................................................
Don't launch in articles with no text This is a silly bug. Change-Id: I5d54cda34d5b7f383c182e41da13dfce141e36bb --- M resources/mmv/mmv.bootstrap.js 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Gilles: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/mmv/mmv.bootstrap.js b/resources/mmv/mmv.bootstrap.js index 55bfdad..f308af0 100755 --- a/resources/mmv/mmv.bootstrap.js +++ b/resources/mmv/mmv.bootstrap.js @@ -121,9 +121,14 @@ return; } - if ( $thumb.closest( '.metadata' ).length > 0 ) { + if ( // This is almost certainly an icon for an informational template like // {{refimprove}} on enwiki. + $thumb.closest( '.metadata' ).length > 0 || + + // This is an article with no text. + $thumb.closest( '.noarticletext' ).length > 0 + ) { return; } -- To view, visit https://gerrit.wikimedia.org/r/118124 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d54cda34d5b7f383c182e41da13dfce141e36bb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MultimediaViewer Gerrit-Branch: master Gerrit-Owner: MarkTraceur <mtrac...@member.fsf.org> Gerrit-Reviewer: Gergő Tisza <gti...@wikimedia.org> Gerrit-Reviewer: Gilles <gdu...@wikimedia.org> Gerrit-Reviewer: MarkTraceur <mtrac...@member.fsf.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits