jenkins-bot has submitted this change and it was merged. Change subject: Use square brackets instead of curly braces for char of a string ......................................................................
Use square brackets instead of curly braces for char of a string The use of curly braces is deprecated in php 4.0, so changing it to square brackets Change-Id: Ia820cea34d2bd92fe1c3bc8fd773942a425ec90a --- M includes/User.php M includes/specials/SpecialRunJobs.php 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Siebrand: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/User.php b/includes/User.php index a897d21..dd8717f 100644 --- a/includes/User.php +++ b/includes/User.php @@ -1123,7 +1123,7 @@ } else { $result = 0; for ( $i = 0; $i < strlen( $answer ); $i++ ) { - $result |= ord( $answer{$i} ) ^ ord( $test{$i} ); + $result |= ord( $answer[$i] ) ^ ord( $test[$i] ); } $passwordCorrect = ( $result == 0 ); } diff --git a/includes/specials/SpecialRunJobs.php b/includes/specials/SpecialRunJobs.php index 8a4026d..ab2b16e 100644 --- a/includes/specials/SpecialRunJobs.php +++ b/includes/specials/SpecialRunJobs.php @@ -69,7 +69,7 @@ } else { $result = 0; for ( $i = 0; $i < strlen( $cSig ); $i++ ) { - $result |= ord( $cSig{$i} ) ^ ord( $rSig{$i} ); + $result |= ord( $cSig[$i] ) ^ ord( $rSig[$i] ); } $verified = ( $result == 0 ); } -- To view, visit https://gerrit.wikimedia.org/r/119529 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia820cea34d2bd92fe1c3bc8fd773942a425ec90a Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: Siebrand <siebr...@kitano.nl> Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits