Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/119912
Change subject: Block non-JSON API access to VisualEditor, as it won't work
......................................................................
Block non-JSON API access to VisualEditor, as it won't work
Bug: 61017
Change-Id: I1d8f4509fc012bf5da91d2fd431651e55291edfa
---
M ApiVisualEditor.php
1 file changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/12/119912/1
diff --git a/ApiVisualEditor.php b/ApiVisualEditor.php
index a40fb40..0983162 100644
--- a/ApiVisualEditor.php
+++ b/ApiVisualEditor.php
@@ -304,6 +304,17 @@
$user = $this->getUser();
$params = $this->extractRequestParams();
+
+ $format = $params['format'];
+ $allowed = array( 'json', 'jsonfm' );
+ if !( in_array( $format, $allowed ) ) {
+ $this->dieUsage(
+ 'Invalid format; the VisualEditor API can only
be used as JSON " .
+ "and JSONfm, not "' . $params['format']
. '".',
+ 'invalidformat'
+ );
+ }
+
$page = Title::newFromText( $params['page'] );
if ( !$page ) {
$this->dieUsageMsg( 'invalidtitle', $params['page'] );
--
To view, visit https://gerrit.wikimedia.org/r/119912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d8f4509fc012bf5da91d2fd431651e55291edfa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
