jenkins-bot has submitted this change and it was merged. Change subject: Make the modal expand to fit its contents ......................................................................
Make the modal expand to fit its contents Make the modal expand to fit its contents in non-IE and IE8+ so that the buttons are displayed on one line in all languages Generally maintain the current behaviour in IE6/7, except that the 'no thanks' link is fixed, text is centered, and the second button is shifted down in some scenarios, rather than forcing the modal to scroll. Bug: 61922 Change-Id: I6069e8e7139aabde432ff2dc8d5b902dbd17e2ae --- M resources/ext.gettingstarted.return.less 1 file changed, 11 insertions(+), 6 deletions(-) Approvals: Mattflaschen: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/ext.gettingstarted.return.less b/resources/ext.gettingstarted.return.less index baab872..2e3b5ed 100644 --- a/resources/ext.gettingstarted.return.less +++ b/resources/ext.gettingstarted.return.less @@ -2,7 +2,7 @@ /* Specific elements */ #mw-gettingstarted-cta-editable-main-page { - width: 510px; + width: 510px !ie; } #mw-gettingstarted-cta-other-page { @@ -64,9 +64,11 @@ .mw-gettingstarted-cta-container { display: table-cell; vertical-align: middle; + text-align: center; display: block !ie; position: absolute !ie; top: 50% !ie; + left: 50% !ie; } /* @@ -82,13 +84,17 @@ overflow: auto; /* One z-index above overlay above */ z-index: 100000007; + display: inline-block; + text-align: left; + display: block !ie; position: relative !ie; top: -50% !ie; + left: -50% !ie; .mw-ui-button { - display: table; - float: left; - text-align: left; + display: inline-block; + vertical-align: top; + text-align: inherit; margin-right: 20px; margin-bottom: 0px; margin-top: 15px; @@ -159,8 +165,7 @@ } .mw-gettingstarted-cta-leave-link { - float: left; - clear: both; margin-top: 20px; font-size: 0.8em; + display: block; } -- To view, visit https://gerrit.wikimedia.org/r/118088 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6069e8e7139aabde432ff2dc8d5b902dbd17e2ae Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/GettingStarted Gerrit-Branch: master Gerrit-Owner: Phuedx <g...@samsmith.io> Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: Phuedx <g...@samsmith.io> Gerrit-Reviewer: Swalling <swall...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits