jenkins-bot has submitted this change and it was merged.
Change subject: Revert "Remove unneeded show() in WikiEditor toolbar"
......................................................................
Revert "Remove unneeded show() in WikiEditor toolbar"
because apparently we do have empty tools boxes. Alternative
implementation in I4652ade66c6de864ee3e74b3817ed9b93967ce3d
This reverts commit dd46fc383b7b427f0824249deb078fd64a0d578d.
Change-Id: I358c34d63261989d49b0a4156cbc05b544727d5c
---
M modules/jquery.wikiEditor.toolbar.js
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
TheDJ: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/jquery.wikiEditor.toolbar.js
b/modules/jquery.wikiEditor.toolbar.js
index 884240a..d5f383b 100644
--- a/modules/jquery.wikiEditor.toolbar.js
+++ b/modules/jquery.wikiEditor.toolbar.js
@@ -61,6 +61,9 @@
// Tool
$group.append(
$.wikiEditor.modules.toolbar.fn.buildTool( context, tool, data[type][tool] ) );
}
+ if ( $group.children().length ) {
+ $group.show();
+ }
smooth = false;
break;
case 'pages':
--
To view, visit https://gerrit.wikimedia.org/r/120599
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I358c34d63261989d49b0a4156cbc05b544727d5c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
