Tobias Gritschacher has uploaded a new change for review. https://gerrit.wikimedia.org/r/120771
Change subject: Make entityselector always trigger aftersetentity event ...................................................................... Make entityselector always trigger aftersetentity event This reverts commit 3d2b65ee905e871e8cf0465857ceea0056726419. Change-Id: I2f8c263b6b5dc3bfaee91ae7b73f00dbb4c2c37d --- M lib/resources/experts/EntityIdInput.js M lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js 2 files changed, 2 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/71/120771/1 diff --git a/lib/resources/experts/EntityIdInput.js b/lib/resources/experts/EntityIdInput.js index 187f52e..8995dbc 100644 --- a/lib/resources/experts/EntityIdInput.js +++ b/lib/resources/experts/EntityIdInput.js @@ -63,7 +63,7 @@ } ) .on( - 'eachchange entityselectorselect entityselectoraftersetentity', + 'eachchange entityselectoraftersetentity', function( e ) { // Entity selector's value is actual value after change. self._actualValue = false; diff --git a/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js b/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js index c843948..1248d9e 100644 --- a/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js +++ b/lib/resources/jquery.wikibase/jquery.wikibase.entityselector.js @@ -683,6 +683,7 @@ url: entity.url }; } + this._trigger( 'aftersetentity', 0, [ entity ? entity.id : null ] ); }, /** @@ -708,8 +709,6 @@ self._setEntity( entity ); self.element.val( label ); - - self._trigger( 'aftersetentity', 0, [ entity ? entity.id : null ] ); }; if ( entity === undefined ) { -- To view, visit https://gerrit.wikimedia.org/r/120771 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2f8c263b6b5dc3bfaee91ae7b73f00dbb4c2c37d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits