Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/120807
Change subject: Collection of small fixes
......................................................................
Collection of small fixes
Change-Id: I61ebf465a8763a184cb0343d63b8ef225eb74931
---
M MessageCollection.php
M utils/MessageHandle.php
M utils/MessageIndex.php
3 files changed, 5 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/07/120807/1
diff --git a/MessageCollection.php b/MessageCollection.php
index 9ef7d57..7900856 100644
--- a/MessageCollection.php
+++ b/MessageCollection.php
@@ -268,7 +268,6 @@
unset( $this->tags['fuzzy'] );
$this->reverseMap = null;
- $this->getReverseMap();
}
/**
@@ -676,10 +675,10 @@
$fields = array( 'page_namespace', 'page_title', 'trr_user' );
$conds = $this->getTitleConds( $dbr );
$joins = array( 'translate_reviews' =>
- array(
- 'JOIN',
- array( 'page_id=trr_page', 'page_latest=trr_revision' )
- )
+ array(
+ 'JOIN',
+ array( 'page_id=trr_page',
'page_latest=trr_revision' )
+ )
);
$this->dbReviewData = $dbr->select( $tables, $fields, $conds,
__METHOD__, array(), $joins );
diff --git a/utils/MessageHandle.php b/utils/MessageHandle.php
index 9215b51..15423d8 100644
--- a/utils/MessageHandle.php
+++ b/utils/MessageHandle.php
@@ -47,7 +47,7 @@
$title = $this->getTitle();
// Check if this is a valid message first
$this->key = $title->getDBKey();
- $known = count( MessageIndex::singleton()->getGroupIds(
$this ) );
+ $known = MessageIndex::singleton()->getGroupIds( $this
) !== array();
$pos = strrpos( $this->key, '/' );
if ( $known || $pos === false ) {
diff --git a/utils/MessageIndex.php b/utils/MessageIndex.php
index 99b92d6..741e20b 100644
--- a/utils/MessageIndex.php
+++ b/utils/MessageIndex.php
@@ -471,14 +471,12 @@
}
}
- wfProfileIn( __METHOD__ );
$value = $reader->get( $key );
if ( !is_string( $value ) ) {
$value = null;
} else {
$value = $this->unserialize( $value );
}
- wfProfileOut( __METHOD__ );
return $value;
}
--
To view, visit https://gerrit.wikimedia.org/r/120807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61ebf465a8763a184cb0343d63b8ef225eb74931
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
