IAlex has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/120848

Change subject: Remove wfDebugLog() call from wfSetupSession()
......................................................................

Remove wfDebugLog() call from wfSetupSession()

Since Iffba121a99 (00b7f76) with the removal of wfHttpOnlySafe(),
session cookie's parameters are based only on configuration
settings, so there is no point to spam the "cookie" log group
with predicitible values.

Change-Id: I8b1cdea929cefc32dd8b01c2ecbf2d76bb64189f
---
M includes/GlobalFunctions.php
1 file changed, 0 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/48/120848/1

diff --git a/includes/GlobalFunctions.php b/includes/GlobalFunctions.php
index f0b0a8d..2314cb2 100644
--- a/includes/GlobalFunctions.php
+++ b/includes/GlobalFunctions.php
@@ -3513,14 +3513,6 @@
                # hasn't already been set to the desired value (that causes 
errors)
                ini_set( 'session.save_handler', $wgSessionHandler );
        }
-       wfDebugLog( 'cookie',
-               'session_set_cookie_params: "' . implode( '", "',
-                       array(
-                               0,
-                               $wgCookiePath,
-                               $wgCookieDomain,
-                               $wgCookieSecure,
-                               $wgCookieHttpOnly ) ) . '"' );
        session_set_cookie_params(
                0, $wgCookiePath, $wgCookieDomain, $wgCookieSecure, 
$wgCookieHttpOnly );
        session_cache_limiter( 'private, must-revalidate' );

-- 
To view, visit https://gerrit.wikimedia.org/r/120848
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b1cdea929cefc32dd8b01c2ecbf2d76bb64189f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: IAlex <coderev...@emsenhuber.ch>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to