Santhosh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/121578
Change subject: Refactor the render code for translation column
......................................................................
Refactor the render code for translation column
Simplify jquery appends
Change-Id: I86f85fa04087515429ffcd971967a85203ce11fd
---
M modules/translation/ext.cx.translation.js
1 file changed, 11 insertions(+), 16 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/78/121578/1
diff --git a/modules/translation/ext.cx.translation.js
b/modules/translation/ext.cx.translation.js
index 9824d11..eed5bc4 100644
--- a/modules/translation/ext.cx.translation.js
+++ b/modules/translation/ext.cx.translation.js
@@ -30,7 +30,7 @@
};
ContentTranslationEditor.prototype.render = function () {
- var $content;
+ var $content, $heading, $languageLabel, $subHeading;
if ( mw.cx.targetLanguage ) {
this.$container.prop( {
@@ -38,29 +38,24 @@
dir: $.uls.data.getDir( mw.cx.targetLanguage )
} );
}
-
- this.$container.append(
- $( '<h2>' )
+ $heading = $( '<h2>' )
.attr( 'contenteditable', true )
.addClass( 'cx-column__title' )
- .text( $( '.cx-column--source .cx-column__title'
).text() )
- );
+ .text( $( '.cx-column--source .cx-column__title'
).text() );
+ this.$container.append( $heading );
if ( mw.cx.targetLanguage ) {
this.$container.prop( {
lang: mw.cx.targetLanguage,
dir: $.uls.data.getDir( mw.cx.targetLanguage )
} );
-
- this.$container.append(
- $( '<div>' )
- .addClass( 'cx-column__sub-heading' )
- .append(
- $( '<span>' )
- .addClass(
'cx-column__language-label' )
- .text(
$.uls.data.getAutonym( mw.cx.targetLanguage ) )
- )
- );
+ $languageLabel = $( '<span>' )
+ .addClass( 'cx-column__language-label' )
+ .text( $.uls.data.getAutonym(
mw.cx.targetLanguage ) );
+ $subHeading = $( '<div>' )
+ .addClass( 'cx-column__sub-heading' )
+ .append( $languageLabel );
+ this.$container.append( $subHeading );
}
$content = $( '<div>' )
--
To view, visit https://gerrit.wikimedia.org/r/121578
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86f85fa04087515429ffcd971967a85203ce11fd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
