Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/121654
Change subject: Cleanup WikibaseClient "use" section
......................................................................
Cleanup WikibaseClient "use" section
I removed classes from the "use" section that are only used a
single time in a comment. Reasoning:
WikibaseClient does not really depend on these classes. PHP doesn't
care what these methods return. The only reason to mention the
classes in the comments is to have nice hints in the IDE.
The benefit of making these few comments a bit longer is a more
meaningful "use" section.
See Id7bca7eae7dfc7607311d6310024a0fa02f470df for the same change
in WikibaseRepo.
Change-Id: Ie072f7965c8f8579bb5644dbb3d1ed1669a7b1ca
---
M client/includes/WikibaseClient.php
1 file changed, 9 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/54/121654/1
diff --git a/client/includes/WikibaseClient.php
b/client/includes/WikibaseClient.php
index 41ce354..a335a4a 100644
--- a/client/includes/WikibaseClient.php
+++ b/client/includes/WikibaseClient.php
@@ -6,25 +6,23 @@
use Exception;
use Language;
use Site;
+use Sites;
use SiteSQLStore;
use SiteStore;
-use Sites;
use ValueFormatters\FormatterOptions;
use Wikibase\ClientStore;
use Wikibase\DataModel\Entity\BasicEntityIdParser;
use Wikibase\DataModel\Entity\DispatchingEntityIdParser;
-use Wikibase\DataModel\Entity\EntityIdParser;
-use Wikibase\EntityLookup;
use Wikibase\LangLinkHandler;
use Wikibase\LanguageFallbackChainFactory;
use Wikibase\Lib\EntityIdFormatter;
use Wikibase\Lib\EntityIdLabelFormatter;
use Wikibase\Lib\EntityRetrievingDataTypeLookup;
+use Wikibase\Lib\OutputFormatSnakFormatterFactory;
use Wikibase\Lib\OutputFormatValueFormatterFactory;
use Wikibase\Lib\PropertyDataTypeLookup;
use Wikibase\Lib\PropertyInfoDataTypeLookup;
use Wikibase\Lib\SnakFormatter;
-use Wikibase\Lib\OutputFormatSnakFormatterFactory;
use Wikibase\Lib\WikibaseDataTypeBuilders;
use Wikibase\Lib\WikibaseSnakFormatterBuilders;
use Wikibase\Lib\WikibaseValueFormatterBuilders;
@@ -127,11 +125,13 @@
* @param Language $contentLanguage
* @param SiteStore $siteStore
*/
- public function __construct( SettingsArray $settings, Language
$contentLanguage,
+ public function __construct(
+ SettingsArray $settings,
+ Language $contentLanguage,
SiteStore $siteStore = null
) {
- $this->contentLanguage = $contentLanguage;
$this->settings = $settings;
+ $this->contentLanguage = $contentLanguage;
$this->siteStore = $siteStore;
}
@@ -160,7 +160,7 @@
/**
* @since 0.4
*
- * @return EntityIdParser
+ * @return \Wikibase\DataModel\Entity\EntityIdParser
*/
public function getEntityIdParser() {
//TODO: make the ID builders configurable
@@ -197,7 +197,7 @@
}
/**
- * @return EntityLookup
+ * @return \Wikibase\EntityLookup
*/
private function getEntityLookup() {
return $this->getStore()->getEntityLookup();
@@ -564,4 +564,5 @@
return $this->langLinkHandler;
}
+
}
--
To view, visit https://gerrit.wikimedia.org/r/121654
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie072f7965c8f8579bb5644dbb3d1ed1669a7b1ca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
