jenkins-bot has submitted this change and it was merged.
Change subject: Get rid of term "handle" in the context of items in browsertest
features
......................................................................
Get rid of term "handle" in the context of items in browsertest features
Change-Id: I3f5eeaf5252fa351c8927f705076ebbef0ce976b
---
M tests/browser/features/statements_item.feature
M tests/browser/features/step_definitions/entity_steps.rb
M tests/browser/features/step_definitions/statement_steps.rb
3 files changed, 8 insertions(+), 8 deletions(-)
Approvals:
WikidataJenkins: Verified
Thiemo Mättig (WMDE): Verified; Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/statements_item.feature
b/tests/browser/features/statements_item.feature
index ca8a23a..d250219 100644
--- a/tests/browser/features/statements_item.feature
+++ b/tests/browser/features/statements_item.feature
@@ -17,11 +17,11 @@
Scenario Outline: Adding a statement of type item
Given There are properties with the following handles and datatypes:
| itemprop | wikibase-item |
- Given There are items with the following handles:
+ Given I have the following items:
| item1 |
When I click the statement add button
And I select the property itemprop
- And I enter the label of the item with handle <itemhandle> as statement
value
+ And I enter the label of item <item> as statement value
And I <save>
Then Statement add button should be there
And Statement cancel button should not be there
@@ -30,8 +30,8 @@
And Statement value input element should not be there
And Statement edit button for claim 1 in group 1 should be there
And Statement name of group 1 should be the label of itemprop
- And Statement value of claim 1 in group 1 should be the label of the item
with handle <itemhandle>
+ And Statement value of claim 1 in group 1 should be the label of item
<item>
Examples:
- | itemhandle | save |
- | item1 | click the statement save button |
+ | item | save |
+ | item1 | click the statement save button |
diff --git a/tests/browser/features/step_definitions/entity_steps.rb
b/tests/browser/features/step_definitions/entity_steps.rb
index 7377713..560114e 100644
--- a/tests/browser/features/step_definitions/entity_steps.rb
+++ b/tests/browser/features/step_definitions/entity_steps.rb
@@ -23,7 +23,7 @@
@properties = wb_api.wb_create_properties(props.raw)
end
-Given /^There are items with the following handles:$/ do |handles|
+Given /^I have the following items:$/ do |handles|
wb_api = WikibaseAPI::Gateway.new(URL.repo_api)
@items = wb_api.wb_create_items(handles.raw)
end
diff --git a/tests/browser/features/step_definitions/statement_steps.rb
b/tests/browser/features/step_definitions/statement_steps.rb
index 1405d29..c20f13e 100644
--- a/tests/browser/features/step_definitions/statement_steps.rb
+++ b/tests/browser/features/step_definitions/statement_steps.rb
@@ -44,7 +44,7 @@
end
end
-When /^I enter the label of the item with handle (.+) as statement value$/ do
|handle|
+When /^I enter the label of item (.+) as statement value$/ do |handle|
on(ItemPage) do |page|
page.statement_value_input_field_element.clear
page.statement_value_input_field = @items[handle]["label"]
@@ -126,6 +126,6 @@
on(ItemPage).statement_string_value(group_index, claim_index).should == value
end
-Then /^Statement value of claim (.+) in group (.+) should be the label of the
item with handle (.+)$/ do |claim_index, group_index, handle|
+Then /^Statement value of claim (.+) in group (.+) should be the label of item
(.+)$/ do |claim_index, group_index, handle|
on(ItemPage).statement_value_element(group_index, claim_index).text.should
== @items[handle]["label"]
end
--
To view, visit https://gerrit.wikimedia.org/r/121669
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f5eeaf5252fa351c8927f705076ebbef0ce976b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
Gerrit-Reviewer: WikidataJenkins <wikidata-servi...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
