[MediaWiki-commits] [Gerrit] Add snak variation css class in non-JS claim html - change (mediawiki...Wikibase)

[Aude (Code Review)]

Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/121668

Change subject: Add snak variation css class in non-JS claim html
......................................................................

Add snak variation css class in non-JS claim html

Change-Id: Ie90c65e39fe5b5f6c47bb84d6335ac3dac467312
---
M lib/resources/templates.php
M repo/includes/ClaimHtmlGenerator.php
2 files changed, 23 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/68/121668/2

diff --git a/lib/resources/templates.php b/lib/resources/templates.php
index 3292fdb..d8f49e4 100644
--- a/lib/resources/templates.php
+++ b/lib/resources/templates.php
@@ -114,7 +114,7 @@
        </div>
        <div class="wb-snak-value-container" dir="auto">
                <div class="wb-snak-typeselector"></div>
-               <div class="wb-snak-value">$2</div>
+               <div class="wb-snak-value $2">$3</div>
        </div>
 </div>
 HTML;
diff --git a/repo/includes/ClaimHtmlGenerator.php 
b/repo/includes/ClaimHtmlGenerator.php
index d6936fa..52949ad 100644
--- a/repo/includes/ClaimHtmlGenerator.php
+++ b/repo/includes/ClaimHtmlGenerator.php
@@ -229,20 +229,41 @@
                        );
                }
 
+               $snakViewVariation = $this->getSnakViewVariation( $snak );
+               $snakViewCssClass = 'wb-snakview-variation-' . 
$snakViewVariation;
+
                $formattedValue = $this->getFormattedSnakValue( $snak );
 
-               if( $formattedValue === '' ) {
+               if ( $formattedValue === '' ) {
                        $formattedValue = '&nbsp;';
                }
 
                return wfTemplate( 'wb-snak',
                        // Display property link only once for snaks featuring 
the same property:
                        $propertyLink,
+                       $snakViewCssClass,
                        $formattedValue
                );
        }
 
        /**
+        * @param Snak $snak
+        *
+        * @return string
+        */
+       private function getSnakViewVariation( Snak $snak ) {
+               if ( $snak instanceof PropertyValueSnak ) {
+                       $variation = 'valuesnak';
+               } elseif ( $snak instanceof PropertySomeValueSnak ) {
+                       $variation = 'somevaluesnak';
+               } else {
+                       $variation = 'novaluesnak';
+               }
+
+               return $variation;
+       }
+
+       /**
         * @fixme handle errors more consistently as done in JS UI, and perhaps 
add
         * localised exception messages.
         *

-- 
To view, visit https://gerrit.wikimedia.org/r/121668
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie90c65e39fe5b5f6c47bb84d6335ac3dac467312
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits