Pcoombe has uploaded a new change for review. https://gerrit.wikimedia.org/r/121690
Change subject: Change email address inputs in GC forms to use type="email" ...................................................................... Change email address inputs in GC forms to use type="email" Use the HTML5 attribute type="email" on email address input elements. Most browsers will recognise this, and mobile browsers will use a soft keyboard more suited to inputting an email address. Browsers which don't recognise it will seamlessly fall back to type="text" See http://diveintohtml5.info/forms.html#type-email for more info Also change CSS so inputs with type="email" are styled the same as type="text" Change-Id: I2c6856bdfcc5fe0b0413b67fc05d262ed8200aba --- M globalcollect_gateway/forms/html/_personal-information/BR.html M globalcollect_gateway/forms/html/_personal-information/CA.html M globalcollect_gateway/forms/html/_personal-information/GB.html M globalcollect_gateway/forms/html/_personal-information/JP.html M globalcollect_gateway/forms/html/_personal-information/US.html M globalcollect_gateway/forms/html/_personal-information/default.html M modules/css/gateway.css 7 files changed, 9 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface refs/changes/90/121690/1 diff --git a/globalcollect_gateway/forms/html/_personal-information/BR.html b/globalcollect_gateway/forms/html/_personal-information/BR.html index 10a3d11..7d90daa 100644 --- a/globalcollect_gateway/forms/html/_personal-information/BR.html +++ b/globalcollect_gateway/forms/html/_personal-information/BR.html @@ -65,7 +65,7 @@ </tr> <tr> <td colspan="2"> - <input class="fullwidth" name="emailAdd" value="@emailAdd" type="text" title="%donate_interface-donor-email%" placeholder="%donate_interface-donor-email%" id="emailAdd"> + <input class="fullwidth" name="emailAdd" value="@emailAdd" type="email" title="%donate_interface-donor-email%" placeholder="%donate_interface-donor-email%" id="emailAdd"> </td> </tr> diff --git a/globalcollect_gateway/forms/html/_personal-information/CA.html b/globalcollect_gateway/forms/html/_personal-information/CA.html index 85ad76d..d088fee 100644 --- a/globalcollect_gateway/forms/html/_personal-information/CA.html +++ b/globalcollect_gateway/forms/html/_personal-information/CA.html @@ -50,6 +50,6 @@ </tr> <tr> <td colspan="2"> - <input class="fullwidth" name="emailAdd" value="@emailAdd" type="text" title="%donate_interface-donor-email%" placeholder="%donate_interface-donor-email%" id="emailAdd"> + <input class="fullwidth" name="emailAdd" value="@emailAdd" type="email" title="%donate_interface-donor-email%" placeholder="%donate_interface-donor-email%" id="emailAdd"> </td> </tr> diff --git a/globalcollect_gateway/forms/html/_personal-information/GB.html b/globalcollect_gateway/forms/html/_personal-information/GB.html index fac7e7f..215ef2e 100644 --- a/globalcollect_gateway/forms/html/_personal-information/GB.html +++ b/globalcollect_gateway/forms/html/_personal-information/GB.html @@ -161,7 +161,7 @@ </tr> <tr> <td colspan="2"> - <input class="fullwidth" name="emailAdd" value="@emailAdd" type="text" title="%donate_interface-donor-email%" placeholder="%donate_interface-donor-email%" id="emailAdd"> + <input class="fullwidth" name="emailAdd" value="@emailAdd" type="email" title="%donate_interface-donor-email%" placeholder="%donate_interface-donor-email%" id="emailAdd"> </td> </tr> \ No newline at end of file diff --git a/globalcollect_gateway/forms/html/_personal-information/JP.html b/globalcollect_gateway/forms/html/_personal-information/JP.html index 22188b4..5a4473b 100644 --- a/globalcollect_gateway/forms/html/_personal-information/JP.html +++ b/globalcollect_gateway/forms/html/_personal-information/JP.html @@ -10,7 +10,7 @@ </tr> <tr> <td colspan="2"> - <input class="fullwidth" name="emailAdd" value="@emailAdd" type="text" title="%donate_interface-donor-email%" placeholder="%donate_interface-donor-email%" id="emailAdd"> + <input class="fullwidth" name="emailAdd" value="@emailAdd" type="email" title="%donate_interface-donor-email%" placeholder="%donate_interface-donor-email%" id="emailAdd"> </td> </tr> <tr class="collapsingCity"> diff --git a/globalcollect_gateway/forms/html/_personal-information/US.html b/globalcollect_gateway/forms/html/_personal-information/US.html index 0ad2baa..1e9fafd 100644 --- a/globalcollect_gateway/forms/html/_personal-information/US.html +++ b/globalcollect_gateway/forms/html/_personal-information/US.html @@ -87,6 +87,6 @@ </tr> <tr> <td colspan="2"> - <input class="fullwidth" name="emailAdd" value="@emailAdd" type="text" title="%donate_interface-donor-email%" placeholder="%donate_interface-donor-email%" id="emailAdd"> + <input class="fullwidth" name="emailAdd" value="@emailAdd" type="email" title="%donate_interface-donor-email%" placeholder="%donate_interface-donor-email%" id="emailAdd"> </td> </tr> diff --git a/globalcollect_gateway/forms/html/_personal-information/default.html b/globalcollect_gateway/forms/html/_personal-information/default.html index 82c86f0..a5afb50 100644 --- a/globalcollect_gateway/forms/html/_personal-information/default.html +++ b/globalcollect_gateway/forms/html/_personal-information/default.html @@ -10,7 +10,7 @@ </tr> <tr> <td colspan="2"> - <input class="fullwidth" name="emailAdd" value="@emailAdd" type="text" title="%donate_interface-donor-email%" placeholder="%donate_interface-donor-email%" id="emailAdd"> + <input class="fullwidth" name="emailAdd" value="@emailAdd" type="email" title="%donate_interface-donor-email%" placeholder="%donate_interface-donor-email%" id="emailAdd"> </td> </tr> <tr class="collapsingCity"> diff --git a/modules/css/gateway.css b/modules/css/gateway.css index 7d29466..2341809 100644 --- a/modules/css/gateway.css +++ b/modules/css/gateway.css @@ -116,7 +116,9 @@ display: none; } -#bodyContent input[type="text"], textarea { +#bodyContent input[type="text"], +#bodyContent input[type="email"], +textarea { border: 1px solid #C0C0C0; padding: 3px; } -- To view, visit https://gerrit.wikimedia.org/r/121690 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2c6856bdfcc5fe0b0413b67fc05d262ed8200aba Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/DonationInterface Gerrit-Branch: master Gerrit-Owner: Pcoombe <pcoo...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
