jenkins-bot has submitted this change and it was merged.
Change subject: Enable Special:MobileMenu for Vector skin
......................................................................
Enable Special:MobileMenu for Vector skin
Needed to support beta experiment Winter
in I1492f2aaadd037674007fd973f0af2bf9f2306ae
This provides fallback menu for non-JS users there.
Change-Id: Id75b675ea9b4d332c5350026609897c8ebb40b01
---
M includes/Resources.php
M includes/specials/SpecialMobileMenu.php
A less/desktop/special/mobilemenu.less
3 files changed, 25 insertions(+), 3 deletions(-)
Approvals:
JGonera: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Resources.php b/includes/Resources.php
index cf169ca..cfba67f 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -990,6 +990,9 @@
'styles' => array(
'less/specials/mobilemenu.less',
),
+ 'skinStyles' => array(
+ 'vector' => 'less/desktop/special/mobilemenu.less',
+ )
),
'mobile.special.mobileoptions.styles' =>
$wgMFMobileSpecialPageResourceBoilerplate + array(
'styles' => array(
diff --git a/includes/specials/SpecialMobileMenu.php
b/includes/specials/SpecialMobileMenu.php
index b6039a4..d6d04b8 100644
--- a/includes/specials/SpecialMobileMenu.php
+++ b/includes/specials/SpecialMobileMenu.php
@@ -1,10 +1,17 @@
<?php
-
+/**
+ * Special page designed for rendering a skin's menu without an article
+ * Used for skins where the menu is hidden via JavaScript by default.
+ *
+ * @ingroup SpecialPage
+ */
+// FIXME: Rename from MobileMenu to NavigationMenu
class SpecialMobileMenu extends MobileSpecialPage {
public function __construct() {
parent::__construct( 'MobileMenu' );
- // Make mobile menu available to non-JavaScript users of
Minerva skin
- if( $this->getSkin()->getSkinName() === 'minerva' ) {
+ $supported = array( 'vector', 'minerva' );
+ $name = $this->getSkin()->getSkinName();
+ if ( array_search( $name, $supported ) !== false ) {
$this->hasDesktopVersion = true;
}
}
diff --git a/less/desktop/special/mobilemenu.less
b/less/desktop/special/mobilemenu.less
new file mode 100644
index 0000000..6b0ad5f
--- /dev/null
+++ b/less/desktop/special/mobilemenu.less
@@ -0,0 +1,12 @@
+// For Vector skin
+#footer,
+#mw-head,
+#content {
+ display: none;
+}
+
+.ns-special.page-Special_MobileMenu {
+ div#mw-panel {
+ width: 100%;
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/118118
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id75b675ea9b4d332c5350026609897c8ebb40b01
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: JGonera <jgon...@wikimedia.org>
Gerrit-Reviewer: MaxSem <maxsem.w...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
